You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "mindhawk (JIRA)" <ji...@apache.org> on 2009/12/02 03:01:22 UTC
[jira] Created: (TAP5-940) Zone should fire a heart beat event
Zone should fire a heart beat event
-----------------------------------
Key: TAP5-940
URL: https://issues.apache.org/jira/browse/TAP5-940
Project: Tapestry 5
Issue Type: Bug
Affects Versions: 5.1.0.5
Reporter: mindhawk
Priority: Minor
If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Seth Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790401#action_12790401 ]
Seth Call commented on TAP5-940:
--------------------------------
Just spent a few hours debugging this one.
A mixin that one could add to a Zone would work too, no?
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-940:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "mindhawk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790542#action_12790542 ]
mindhawk commented on TAP5-940:
-------------------------------
I have tried this, but I found that if I return zone from a event handler, everything is ok except there is another dive inside the previous one. But if I return zone.getBody(), the heartbeat mixin the zone sames does not work.
So, I have write another Zone component myself:
<div t:id="zone" xmlns:t="http://tapestry.apache.org/schema/tapestry_5_0_0.xsd">
<div t:id="heartbeat">
<t:body/>
</div>
</div>
It is works fine. The "heartbeat" component is a non-rendering component which only fire a heartbeat event
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-940:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-940.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
There was already a Heartbeat in place for the partial page render
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Seth Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790425#action_12790425 ]
Seth Call commented on TAP5-940:
--------------------------------
/** The following is a workaround for this issue */
import org.apache.tapestry5.annotations.*;
import org.apache.tapestry5.corelib.components.Zone;
import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.services.Heartbeat;
import org.apache.tapestry5.services.Request;
/** Place on zones sent back in Ajax to fix https://issues.apache.org/jira/browse/TAP5-940 */
public class BmBm {
@Environmental
private Heartbeat heartbeat;
@InjectContainer
private Zone zone;
@Inject
private Request request;
@BeginRender
public void beginRender() {
if (request.isXHR()) {
heartbeat.begin();
}
}
@AfterRender
public void afterRender() {
if (request.isXHR()) {
heartbeat.end();
}
}
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784963#action_12784963 ]
Howard M. Lewis Ship commented on TAP5-940:
-------------------------------------------
An obvious workaround would be to include, in the body of the Zone, a non-rendering component that starts and ends a heartbeat.
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Seth Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790425#action_12790425 ]
Seth Call commented on TAP5-940:
--------------------------------
/** The following is a workaround for this issue */
import org.apache.tapestry5.annotations.*;
import org.apache.tapestry5.corelib.components.Zone;
import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.services.Heartbeat;
import org.apache.tapestry5.services.Request;
/** Place on zones sent back in Ajax to fix https://issues.apache.org/jira/browse/TAP5-940 */
public class BmBm {
@Environmental
private Heartbeat heartbeat;
@InjectContainer
private Zone zone;
@Inject
private Request request;
@BeginRender
public void beginRender() {
if (request.isXHR()) {
heartbeat.begin();
}
}
@AfterRender
public void afterRender() {
if (request.isXHR()) {
heartbeat.end();
}
}
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "mindhawk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790542#action_12790542 ]
mindhawk commented on TAP5-940:
-------------------------------
I have tried this, but I found that if I return zone from a event handler, everything is ok except there is another dive inside the previous one. But if I return zone.getBody(), the heartbeat mixin the zone sames does not work.
So, I have write another Zone component myself:
<div t:id="zone" xmlns:t="http://tapestry.apache.org/schema/tapestry_5_0_0.xsd">
<div t:id="heartbeat">
<t:body/>
</div>
</div>
It is works fine. The "heartbeat" component is a non-rendering component which only fire a heartbeat event
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784963#action_12784963 ]
Howard M. Lewis Ship commented on TAP5-940:
-------------------------------------------
An obvious workaround would be to include, in the body of the Zone, a non-rendering component that starts and ends a heartbeat.
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-940) Zone should fire a heart beat event
Posted by "Seth Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790401#action_12790401 ]
Seth Call commented on TAP5-940:
--------------------------------
Just spent a few hours debugging this one.
A mixin that one could add to a Zone would work too, no?
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Priority: Minor
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-940) Zone should fire a heart beat event
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-940.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
There was already a Heartbeat in place for the partial page render
> Zone should fire a heart beat event
> -----------------------------------
>
> Key: TAP5-940
> URL: https://issues.apache.org/jira/browse/TAP5-940
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.1.0.5
> Reporter: mindhawk
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.