You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-dev@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/08/30 16:13:39 UTC

[jira] [Created] (MAPREDUCE-2913) TestMRJobs.testFailingMapper does not assert the correct thing.

TestMRJobs.testFailingMapper does not assert the correct thing.
---------------------------------------------------------------

                 Key: MAPREDUCE-2913
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2, test
    Affects Versions: 0.23.0, 0.24.0
            Reporter: Robert Joseph Evans
             Fix For: 0.23.0, 0.24.0


{code}
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[0].getStatus().FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[1].getStatus().FAILED);
{code}

when optimized would be

{code}
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);
{code}

obviously these assertions will never fail.  If we remove the {code}.FAILED{code} the asserts no longer pass. This could be because MRApp mocks out the task launcher and never actually launches anything.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira