You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2009/08/14 14:45:15 UTC
[jira] Created: (OPENJPA-1245) Move locking tests to a separate
module
Move locking tests to a separate module
---------------------------------------
Key: OPENJPA-1245
URL: https://issues.apache.org/jira/browse/OPENJPA-1245
Project: OpenJPA
Issue Type: Improvement
Components: build / infrastructure
Reporter: Michael Dick
Assignee: Michael Dick
Priority: Minor
Donald Woods first proposed this change but was met with some concerns [1].
While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
[1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744033#action_12744033 ]
Donald Woods commented on OPENJPA-1245:
---------------------------------------
Any reason why you created a new module under trunk for these instead of putting them under openjpa-integration? I'd prefer not creating another trunk module just for one set of tests.....
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dick closed OPENJPA-1245.
---------------------------------
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.0.0-M2
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
> Fix For: 2.0.0-M3
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744130#action_12744130 ]
Michael Dick commented on OPENJPA-1245:
---------------------------------------
I don't really care where these tests go so long as we can execute the rest of the derby tests in a timely manner.
The remarks in OPENJPA-991 look like they entail SQL that executes on a particular connection. I'm not sure why this would require moving the tests to the integration module. To me it looks more similar to what we're doing with profiles in o-p-jdbc/pom.xml (although the SQL would probably reside in the testcase itself).
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved OPENJPA-1245.
-----------------------------------
Resolution: Fixed
resolving
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.0.0-M2
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744106#action_12744106 ]
Donald Woods commented on OPENJPA-1245:
---------------------------------------
Once the locking code correctly uses server-side locks as described in OPENJPA-991, then these tests are going to require DB specific setup and should be located under openjpa-integration....
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dick updated OPENJPA-1245:
----------------------------------
Remaining Estimate: 0h
Original Estimate: 0h
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.0.0-M2
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
> Fix For: 2.0.0-M3
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744074#action_12744074 ]
Michael Dick commented on OPENJPA-1245:
---------------------------------------
The locking tests are part of the core JPA functionality. I don't see them as part of our integration with another product (ie a Bean Validation provider, or the TCK). If we split out other long running tests it might make sense to create an openjpa-tests module but integration didn't seem right to me.
There's really no good place to put these tests. Conceptually they belong in openjpa-persistence-jdbc, but we don't have fine grained control of the JVM used to run the tests (and the derby settings are per jvm).
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1245) Move locking tests to a separate
module
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated OPENJPA-1245:
----------------------------------
Affects Version/s: 2.0.0-M2
Fix Version/s: 2.0.0-M3
> Move locking tests to a separate module
> ---------------------------------------
>
> Key: OPENJPA-1245
> URL: https://issues.apache.org/jira/browse/OPENJPA-1245
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.0.0-M2
> Reporter: Michael Dick
> Assignee: Michael Dick
> Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Donald Woods first proposed this change but was met with some concerns [1].
> While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.
> [1] http://markmail.org/thread/eovueydeaihpyd2c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.