You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AsperforMias (via GitHub)" <gi...@apache.org> on 2026/05/30 09:27:24 UTC
[PR] Fix/attachment for invoke [dubbo-go]
AsperforMias opened a new pull request, #3348:
URL: https://github.com/apache/dubbo-go/pull/3348
### Description
Fixes #2582 (issue)
## Background
After `GenericService2` was removed in v3, generic invoke no longer had a stable way to access response attachments.
This affects migration scenarios from older versions: the generic call itself still works, but callers can no longer read provider-side response attachments as before.
## Solution
This change uses a compatibility-focused approach and does not modify the existing generic filter, protocol invokers, or the core invocation chain.
Specifically, it:
1. restores a `GenericService2` compatibility entry
2. adds response attachment storage/access support to `GenericService` and `GenericService2`
3. stores result attachments back into the generic service instance after proxy invocation returns
4. allows callers to read response attachments via `GetResponseAttachments(ctx)`
## Changes
- add compatible `GenericService2` type and constructor
- add `Client.NewGenericService2(...)`
- add response attachment save/read capability for generic services
- persist response attachments after generic proxy invocation returns
- add focused unit tests
## Compatibility
This is a backward-compatible enhancement:
- it does not change the current `GenericService` invocation style
- it does not modify existing protocol handling logic
- it only restores response attachment access for generic invoke
## Tests
Verified with targeted tests:
- `go test ./filter/generic ./proxy ./config/generic ./client`
### Checklist
- [x] I confirm the target branch is `develop`
- [x] Code has passed local testing
- [x] I have added tests that prove my fix is effective or that my feature works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add compatibility support for response attachments in generic invoke [dubbo-go]
Posted by "AsperforMias (via GitHub)" <gi...@apache.org>.
AsperforMias commented on PR #3348:
URL: https://github.com/apache/dubbo-go/pull/3348#issuecomment-4582597164
issue had been finished by others, closed.
sad, QAQ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add compatibility support for response attachments in generic invoke [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #3348:
URL: https://github.com/apache/dubbo-go/pull/3348#issuecomment-4582445985
are u in our wechat group ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add compatibility support for response attachments in generic invoke [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3348:
URL: https://github.com/apache/dubbo-go/pull/3348#issuecomment-4582430471
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `59.64912%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 52.48%. Comparing base ([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c06813`](https://app.codecov.io/gh/apache/dubbo-go/commit/3c06813ba3a3b901351e46d3351af44d4053222e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 809 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [client/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&filepath=client%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L2NsaWVudC5nbw==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [filter/generic/service.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&filepath=filter%2Fgeneric%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZmlsdGVyL2dlbmVyaWMvc2VydmljZS5nbw==) | 76.19% | [5 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [proxy/proxy.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&filepath=proxy%2Fproxy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvcHJveHkuZ28=) | 50.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #3348 +/- ##
===========================================
+ Coverage 46.76% 52.48% +5.71%
===========================================
Files 295 492 +197
Lines 17172 37850 +20678
===========================================
+ Hits 8031 19864 +11833
- Misses 8287 16381 +8094
- Partials 854 1605 +751
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/3348?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix/attachment for invoke [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3348:
URL: https://github.com/apache/dubbo-go/pull/3348#issuecomment-4582416542
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3348) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3348&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3348&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3348&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3348&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3348&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3348)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add compatibility support for response attachments in generic invoke [dubbo-go]
Posted by "AsperforMias (via GitHub)" <gi...@apache.org>.
AsperforMias commented on PR #3348:
URL: https://github.com/apache/dubbo-go/pull/3348#issuecomment-4582453874
> are u in our wechat group ?你在我们的微信群里吗？
y, name is also"AsperforMias"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: add compatibility support for response attachments in generic invoke [dubbo-go]
Posted by "AsperforMias (via GitHub)" <gi...@apache.org>.
AsperforMias closed pull request #3348: fix: add compatibility support for response attachments in generic invoke
URL: https://github.com/apache/dubbo-go/pull/3348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org