You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "joycebrum (via GitHub)" <gi...@apache.org> on 2023/03/01 13:37:59 UTC

[PR] Set permissions to codeql workflow (logging-log4j2)

joycebrum opened a new pull request, #1316:
URL: https://github.com/apache/logging-log4j2/pull/1316

   ## Changes
   Closes #1289 
   - Set codeql workflo top level permission as read-all, according to other workflows' top level permissions.
   
   ## Checklist
   
   - [ ] Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise
       >I've based on `release-2.x` since basing on 2.x was causing some conflict on CONTRIBUTING.md. Let me know if I should base on `2.x`anyway
   - [ ] `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `spotless:apply` and retry)
   - [ ] Changes contain an entry file in the `src/changelog/.2.x.x` directory
       > Is it also applicable to this type of changes (on the workflows)?
   - [ ] Tests for the changes are provided
   - [x] [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Set permissions to codeql workflow (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #1316:
URL: https://github.com/apache/logging-log4j2/pull/1316


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Set permissions to codeql workflow (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1316:
URL: https://github.com/apache/logging-log4j2/pull/1316#issuecomment-1451626881

   Thanks @joycebrum! I will merge this and close #1289.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org