[GitHub] [iceberg] rdblue commented on a change in pull request #2713: Replace LinkedList usage with ArrayDeque for better performance

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2713:
URL: https://github.com/apache/iceberg/pull/2713#discussion_r654565635



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -37,7 +37,7 @@
  */
 public class TypeWithSchemaVisitor<T> {
   @SuppressWarnings({"checkstyle:VisibilityModifier", "checkstyle:IllegalType"})

Review comment:
       Is the checkstyle suppression still valid?

##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -37,7 +37,7 @@
  */
 public class TypeWithSchemaVisitor<T> {
   @SuppressWarnings({"checkstyle:VisibilityModifier", "checkstyle:IllegalType"})

Review comment:
       Yeah, I thought the visibility modifier one would be. But the illegal type seems like it would be no longer needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org