You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/09/06 01:25:17 UTC
Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
Updated `MesosContainerizerLaunch` to call `os::lsof()`.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
Diff: https://reviews.apache.org/r/68643/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/#review210407
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 19, 2018, 8:37 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68643/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2018, 8:37 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `MesosContainerizerLaunch` to call `os::lsof()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
>
>
> Diff: https://reviews.apache.org/r/68643/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/
-----------------------------------------------------------
(Updated Oct. 20, 2018, 11:37 a.m.)
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
Updated `MesosContainerizerLaunch` to call `os::lsof()`.
Diffs (updated)
-----
src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
Diff: https://reviews.apache.org/r/68643/diff/4/
Changes: https://reviews.apache.org/r/68643/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/
-----------------------------------------------------------
(Updated Oct. 14, 2018, 9:38 p.m.)
Review request for mesos, Gilbert Song and James Peach.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
Updated `MesosContainerizerLaunch` to call `os::lsof()`.
Diffs (updated)
-----
src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
Diff: https://reviews.apache.org/r/68643/diff/3/
Changes: https://reviews.apache.org/r/68643/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/
-----------------------------------------------------------
(Updated Oct. 11, 2018, 10 p.m.)
Review request for mesos, Gilbert Song and James Peach.
Changes
-------
Addressed review comments.
Bugs: MESOS-9152
https://issues.apache.org/jira/browse/MESOS-9152
Repository: mesos
Description
-------
Updated `MesosContainerizerLaunch` to call `os::lsof()`.
Diffs (updated)
-----
src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
Diff: https://reviews.apache.org/r/68643/diff/2/
Changes: https://reviews.apache.org/r/68643/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call
`os::lsof()`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/#review208412
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/launch.cpp
Lines 1141 (patched)
<https://reviews.apache.org/r/68643/#comment292318>
This code was previously before the fork so that is didn't do memory allocation in an async-signal-safe context (i.e. after fork but before exec).
- James Peach
On Sept. 6, 2018, 1:25 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68643/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 1:25 a.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `MesosContainerizerLaunch` to call `os::lsof()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2
>
>
> Diff: https://reviews.apache.org/r/68643/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>