[jira] [Commented] (YARN-3212) RMNode State Transition Update with DECOMMISSIONING state

["Rohith (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493912#comment-14493912 ] 

Rohith commented on YARN-3212:
------------------------------

Hi [~djp], Thanks for working on this improvement..
I gone through the design doc and the approach looks good to me. Let you know if any clarrification required.

Apologies for delayed review.. One comment on the patch
# In the ReconnectNodeTransition,It is not necessarily to check for DECOMMISSIONING state and other stuffs. Because, Reconnected event can trigger only when node state is RUNNING|UNHEALTHY
{code}
if (rmNode.getState() == NodeState.DECOMMISSIONING) {
+          // When node in decommissioning, and no running Apps on this node,
+          // it will return as decommissioned state.
+          deactivateNode(rmNode, NodeState.DECOMMISSIONED);
+          return NodeState.DECOMMISSIONED;
+        }
{code}

> RMNode State Transition Update with DECOMMISSIONING state
> ---------------------------------------------------------
>
>                 Key: YARN-3212
>                 URL: https://issues.apache.org/jira/browse/YARN-3212
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: RMNodeImpl - new.png, YARN-3212-v1.patch, YARN-3212-v2.patch, YARN-3212-v3.patch
>
>
> As proposed in YARN-914, a new state of “DECOMMISSIONING” will be added and can transition from “running” state triggered by a new event - “decommissioning”. 
> This new state can be transit to state of “decommissioned” when Resource_Update if no running apps on this NM or NM reconnect after restart. Or it received DECOMMISSIONED event (after timeout from CLI).
> In addition, it can back to “running” if user decides to cancel previous decommission by calling recommission on the same node. The reaction to other events is similar to RUNNING state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)