You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/02/01 06:19:49 UTC
Review Request: [EC2 Query API] Add filter support for DecsribeAddresses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9220/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
EC2DescribeAddresses doesn't have filter support.
Support will be available for filters -> instance-id and public-ip
This addresses bug CLOUDSTACK-1119.
Diffs
-----
awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
Diff: https://reviews.apache.org/r/9220/diff/
Testing
-------
1. Run ec2-describe-adresses
2. Run ec2-describe-addrsses --filter instance-id=<instances if any the address is associated to> - return the address
3. Run ec2-describe-addresses --filter instance-id=<invalid id> - empty response
Repeat 2 and 3 for public-ip, the address
Thanks,
Likitha Shetty
Re: Review Request: [EC2 Query API] Add filter support for DecsribeAddresses
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9220/#review16324
-----------------------------------------------------------
Ship it!
Reviewed. Commit hash: 2364ada4df2543c75d5a569de73a83f4a235afa8
- Prachi Damle
On Feb. 1, 2013, 5:19 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9220/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 5:19 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> EC2DescribeAddresses doesn't have filter support.
> Support will be available for filters -> instance-id and public-ip
>
>
> This addresses bug CLOUDSTACK-1119.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f
>
> Diff: https://reviews.apache.org/r/9220/diff/
>
>
> Testing
> -------
>
> 1. Run ec2-describe-adresses
> 2. Run ec2-describe-addrsses --filter instance-id=<instances if any the address is associated to> - return the address
> 3. Run ec2-describe-addresses --filter instance-id=<invalid id> - empty response
> Repeat 2 and 3 for public-ip, the address
>
>
> Thanks,
>
> Likitha Shetty
>
>