You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2024/07/18 00:44:03 UTC
[I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
felipecrv opened a new issue, #43316:
URL: https://github.com/apache/arrow/issues/43316
### Describe the enhancement requested
#43190 improves error messages in case of offset overflow when string/binary/list arrays are being concatenated. These values can live inside nested types (e.g. struct), so when concatenating a type like `struct<a: int8, b: list>` an overflow on the recursive concatenation of field `b` should lead to a cast suggestion to `struct<a: int8, b: large_list>`.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "sunby (via GitHub)" <gi...@apache.org>.
sunby commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-2235698684
I would like to take a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-2237927299
@sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-3921275319
This issue has been closed because there has been no activity for the 14 days since the stale warning. Feel free to reopen if this has been closed in error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "sunby (via GitHub)" <gi...@apache.org>.
sunby commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-2238076507
> @sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.
thanks for the advice! I plan to split them into several PRs and start from the struct type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed issue #43316: [C++] Implement cast suggestions for all nested types in Concatenate
URL: https://github.com/apache/arrow/issues/43316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-3547060399
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "laksh-krishna-sharma (via GitHub)" <gi...@apache.org>.
laksh-krishna-sharma commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-2258310891
May I work on this issue with a little bit of your guidance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Implement cast suggestions for all nested types in Concatenate [arrow]
Posted by "sunby (via GitHub)" <gi...@apache.org>.
sunby commented on issue #43316:
URL: https://github.com/apache/arrow/issues/43316#issuecomment-2236464472
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org