You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2009/06/29 17:30:47 UTC
[jira] Created: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
emphemeral cleanup not happening with session timeout
-----------------------------------------------------
Key: ZOOKEEPER-450
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Benjamin Reed
Priority: Blocker
Fix For: 3.2.0
The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725425#action_12725425 ]
Mahadev konar commented on ZOOKEEPER-450:
-----------------------------------------
forgot to mention that the -1 was due to address in use issue in LETest (not related to the patch)...
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-450:
------------------------------------
Attachment: ZOOKEEPER-450.patch
the patch detects the bug and fixes it. i'm not completely sure about the fix. it's simple and works, but there is a little non deterministic corner case: a client issues a close, but the connection drops after the request is received by the server, and the client moves to a new server and continues to use the session, the stray close will come in and close the session. this corner case is not possible with our current client implementation.
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725240#action_12725240 ]
Hadoop QA commented on ZOOKEEPER-450:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12412080/ZOOKEEPER-450.patch
against trunk revision 788872.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/144/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/144/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/144/console
This message is automatically generated.
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-450:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1 for the patch... good catch ben.... I just committed this. thanks!
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-450:
---------------------------------------
Assignee: Benjamin Reed
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-450:
------------------------------------
Attachment: ZOOKEEPER-450.patch
updated the patch to comment on why the checkSession is not needed for the benefit of future maintainers.
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-450:
------------------------------------
Attachment: (was: ZOOKEEPER-450.patch)
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-450:
------------------------------------
Status: Patch Available (was: Open)
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-450) emphemeral cleanup not happening
with session timeout
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726001#action_12726001 ]
Hudson commented on ZOOKEEPER-450:
----------------------------------
Integrated in ZooKeeper-trunk #363 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/363/])
> emphemeral cleanup not happening with session timeout
> -----------------------------------------------------
>
> Key: ZOOKEEPER-450
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-450
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-450.patch
>
>
> The session move patch broke ephemeral cleanup during session expiration. tragically, we didn't have test coverage to detect the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.