You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Paul Foxworthy (JIRA)" <ji...@apache.org> on 2012/10/02 08:47:07 UTC
[jira] [Created] (OFBIZ-5045) Edit Estimated Ship Date or Estimated
Delivery Date brings on date format error
Paul Foxworthy created OFBIZ-5045:
-------------------------------------
Summary: Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
Key: OFBIZ-5045
URL: https://issues.apache.org/jira/browse/OFBIZ-5045
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Paul Foxworthy
On demo site, enter the URL
https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
In Action screenlet, choose Edit Items
In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
Click on Update Items. An error message is displayed to say the date is not in the correct format.
With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5045) Edit Estimated Ship Date or Estimated
Delivery Date brings on date format error
Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Foxworthy updated OFBIZ-5045:
----------------------------------
Attachment: OFBIZ-5045_EditOrderItemEstimatedDates
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467712#comment-13467712 ]
Jacques Le Roux commented on OFBIZ-5045:
----------------------------------------
Paul, Don't forget to click on the "Provide Patch" button, easier for searches later... thanks
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-5045) Edit Estimated Ship Date or Estimated
Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-5045.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 12.04
Release Branch 11.04
Release Branch 10.04
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469204#comment-13469204 ]
Paul Foxworthy commented on OFBIZ-5045:
---------------------------------------
Hi Jacques,
I did set Patch Available! You can see it in the history from Tuesday. Maybe a problem in Jira lost it?
Cheers
Paul
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469276#comment-13469276 ]
Jacques Le Roux commented on OFBIZ-5045:
----------------------------------------
Ha no, sorry Paul,
I guess because Sascha switched the status to resolved and I reopened, my bad for this wrong advice ;)
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-5045:
------------------------------------
This should be backported to releases. I reproduce in stable https://demo-stable.ofbiz.apache.org/ordermgr/control/editOrderItems?orderId=DEMO10091
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468093#comment-13468093 ]
Jacques Le Roux commented on OFBIZ-5045:
----------------------------------------
Backported in
R12.04 r1392909
R11.04 r1393042
R10.04 r1393192
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5045) Edit Estimated Ship Date or
Estimated Delivery Date brings on date format error
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467713#comment-13467713 ]
Jacques Le Roux commented on OFBIZ-5045:
----------------------------------------
I will backport Sascha ;)
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-5045) Edit Estimated Ship Date or Estimated
Delivery Date brings on date format error
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp closed OFBIZ-5045.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Sascha Rodekamp
Hi Paul,
thanks for the Patch it's committed in
Trunk @Rev 1392773
> Edit Estimated Ship Date or Estimated Delivery Date brings on date format error
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-5045
> URL: https://issues.apache.org/jira/browse/OFBIZ-5045
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Paul Foxworthy
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5045_EditOrderItemEstimatedDates
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> On demo site, enter the URL
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10091
> In Action screenlet, choose Edit Items
> In Estimated Delivery Date, use calendar and choose a date. The date presented will be formatted according to your locale.
> Click on Update Items. An error message is displayed to say the date is not in the correct format.
> With the changes for localized dates, there are two input elements, one hidden one for a plain date suitable for conversion to a Timestamp, and the other displayed to the user in localized format. The second input element should not be processed by the updateApprovedOrderItems service.
> updateApprovedOrderItems uses string-map-prefixes of isdm_ and iddm_ for estimated ship and delivery dates respectively. So the maps processed by the service contain both plain and localized dates.
> The patch adds an if statement to ignore members of the isdm and iddm maps with keys that have a suffix of _i18n.
> I have grepped all of the Ofbiz code for any other service that uses dates with string-map-prefix, and updateApprovedOrderItems is the only one, so I believe the problem won't occur anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira