You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "WweiL (via GitHub)" <gi...@apache.org> on 2024/12/13 08:36:57 UTC
[PR] [SPARK-49883][SS][TESTS] RocksDB Fault Tolerance Test [spark]
WweiL opened a new pull request, #49175:
URL: https://github.com/apache/spark/pull/49175
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new test that verifies the correct snapshot version is loaded in ckpt v2.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Test coverage
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Test only addition
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "WweiL (via GitHub)" <gi...@apache.org>.
WweiL commented on PR #49175:
URL: https://github.com/apache/spark/pull/49175#issuecomment-2552960100
@brkyvz mind taking a look? TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #49175:
URL: https://github.com/apache/spark/pull/49175#issuecomment-2581357885
I'm merging on behalf of @brkyvz . Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "WweiL (via GitHub)" <gi...@apache.org>.
WweiL commented on PR #49175:
URL: https://github.com/apache/spark/pull/49175#issuecomment-2547162766
@siying for both questions the answer is yes. This is the trick I have here:
https://github.com/apache/spark/blob/053af1a0fbc34debb729a3e86837b4aeaedb11ca/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala#L3025-L3040
The map will be updated inside commit()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #49175: [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test
URL: https://github.com/apache/spark/pull/49175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "siying (via GitHub)" <gi...@apache.org>.
siying commented on code in PR #49175:
URL: https://github.com/apache/spark/pull/49175#discussion_r1887712275
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -670,6 +670,85 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0)
+ db.put("a", "1")
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ // The second DB writes to version 0 with another uniqueId
+ val versionToUniqueId2 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId2) { db =>
+ db.load(0)
+ db.put("b", "2")
+ db.commit()
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString)
+ db.commit()
+ }
+ }
+
+ // During a load() with linage from the first rocksDB,
+ // the DB should load with data in the first db
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
Review Comment:
`versionToUniqueId1` is still empty? Not sure the point.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -670,6 +670,85 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0)
+ db.put("a", "1")
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ // The second DB writes to version 0 with another uniqueId
+ val versionToUniqueId2 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId2) { db =>
+ db.load(0)
+ db.put("b", "2")
+ db.commit()
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString)
+ db.commit()
+ }
+ }
+
+ // During a load() with linage from the first rocksDB,
+ // the DB should load with data in the first db
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(10)
Review Comment:
Is it V2 at at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "WweiL (via GitHub)" <gi...@apache.org>.
WweiL commented on code in PR #49175:
URL: https://github.com/apache/spark/pull/49175#discussion_r1890958816
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -670,6 +670,85 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0)
+ db.put("a", "1")
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ // The second DB writes to version 0 with another uniqueId
+ val versionToUniqueId2 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId2) { db =>
+ db.load(0)
+ db.put("b", "2")
+ db.commit()
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString)
+ db.commit()
+ }
+ }
+
+ // During a load() with linage from the first rocksDB,
+ // the DB should load with data in the first db
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(10)
Review Comment:
Yes it is
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -670,6 +670,85 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0)
+ db.put("a", "1")
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ // The second DB writes to version 0 with another uniqueId
+ val versionToUniqueId2 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId2) { db =>
+ db.load(0)
+ db.put("b", "2")
+ db.commit()
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1)
+ db.put(version.toString, (version + 1).toString)
+ db.commit()
+ }
+ }
+
+ // During a load() with linage from the first rocksDB,
+ // the DB should load with data in the first db
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
Review Comment:
added assert() to make sure they are not empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "siying (via GitHub)" <gi...@apache.org>.
siying commented on code in PR #49175:
URL: https://github.com/apache/spark/pull/49175#discussion_r1891130924
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -670,6 +670,108 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0, versionToUniqueId1.get(0))
+ db.put("a", "1") // write key a here
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1, versionToUniqueId1.get(version - 1))
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1, versionToUniqueId1.get(version - 1))
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ assert(versionToUniqueId1.nonEmpty)
+
+ // The second DB writes to version 0 with another uniqueId
+ val versionToUniqueId2 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId2) { db =>
Review Comment:
I think in declaration of `withDB()`, we probably should add a comment for `versionToUniqueId`, mentioning that what It is and how it should be used. I think it is even worth considering to make `withDB()` return `(db, versionToUniqueId)`, so that it is clearly an output parameter. But it is already much better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49883][SS][TESTS][FOLLOWUP] RocksDB Fault Tolerance Test [spark]
Posted by "brkyvz (via GitHub)" <gi...@apache.org>.
brkyvz commented on code in PR #49175:
URL: https://github.com/apache/spark/pull/49175#discussion_r1906551504
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -664,12 +664,114 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
// Verify the content of retained versions.
for (version <- 30 to 60) {
- db.load(version, readOnly = true)
+ db.load(version, versionToUniqueId.get(version), readOnly = true)
assert(db.iterator().map(toStr).toSet === Set((version.toString, version.toString)))
}
}
}
+ testWithChangelogCheckpointingEnabled("RocksDB Fault Tolerance: correctly handle when there " +
+ "are multiple snapshot files for the same version") {
+ val enableStateStoreCheckpointIds = true
+ val useColumnFamily = true
+ val remoteDir = Utils.createTempDir().toString
+ new File(remoteDir).delete() // to make sure that the directory gets created
+ val enableChangelogCheckpointingConf =
+ dbConf.copy(enableChangelogCheckpointing = true, minVersionsToRetain = 20,
+ minDeltasForSnapshot = 3)
+
+ // Simulate when there are multiple snapshot files for the same version
+ // The first DB writes to version 0 with uniqueId
+ val versionToUniqueId1 = new mutable.HashMap[Long, String]()
+ withDB(remoteDir, conf = enableChangelogCheckpointingConf,
+ useColumnFamilies = useColumnFamily,
+ enableStateStoreCheckpointIds = enableStateStoreCheckpointIds,
+ versionToUniqueId = versionToUniqueId1) { db =>
+ db.load(0, versionToUniqueId1.get(0))
+ db.put("a", "1") // write key a here
+ db.commit()
+
+ // Add some change log files after the snapshot
+ for (version <- 2 to 5) {
+ db.load(version - 1, versionToUniqueId1.get(version - 1))
+ db.put(version.toString, version.toString) // update "1" -> "1", "2" -> "2", ...
+ db.commit()
+ }
+
+ // doMaintenance uploads the snapshot
+ db.doMaintenance()
+
+ for (version <- 6 to 10) {
+ db.load(version - 1, versionToUniqueId1.get(version - 1))
+ db.put(version.toString, version.toString)
+ db.commit()
+ }
+ }
+
+ assert(versionToUniqueId1.nonEmpty)
Review Comment:
please try to put a message on what the expectation is - and why you expect it to be that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org