You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/20 02:03:59 UTC
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12799
to review the following change.
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Reviewed-on: http://gerrit.cloudera.org:8080/10822
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 335 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/12799/1
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Reviewed-on: http://gerrit.cloudera.org:8080/10822
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12799
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 335 insertions(+), 6 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 08:31:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1:
This is a clean pick.
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:26:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1842
PS1, Line 1842: .error(alterError("functional.alltypes_view"), onDatabase("functional", allExcept(
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:
http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3822
PS1, Line 3822: ParserError(String.format("ALTER %s %s SET OWNER ROLE %s", type, invalid, invalid));
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3823
PS1, Line 3823: ParserError(String.format("ALTER %s %s SET OWNER USER %s", type, invalid, invalid));
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py@99
PS1, Line 99: "
flake8: E121 continuation line under-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py@127
PS1, Line 127: d
flake8: E303 too many blank lines (2)
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:05:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3932/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 04:39:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 07:05:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2472/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:44:58 +0000
Gerrit-HasComments: No