You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/03 04:20:56 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #37287: [SPARK-39912][SQL] Refine CatalogImpl
cloud-fan commented on code in PR #37287:
URL: https://github.com/apache/spark/pull/37287#discussion_r936221109
##########
python/pyspark/sql/catalog.py:
##########
@@ -376,9 +376,9 @@ def getFunction(self, functionName: str) -> Function:
--------
>>> func = spark.sql("CREATE FUNCTION my_func1 AS 'test.org.apache.spark.sql.MyDoubleAvg'")
>>> spark.catalog.getFunction("my_func1")
- Function(name='my_func1', catalog=None, namespace=['default'], ...
+ Function(name='my_func1', catalog=spark_catalog, namespace=['default'], ...
Review Comment:
```suggestion
Function(name='my_func1', catalog='spark_catalog', namespace=['default'], ...
```
##########
python/pyspark/sql/catalog.py:
##########
@@ -376,9 +376,9 @@ def getFunction(self, functionName: str) -> Function:
--------
>>> func = spark.sql("CREATE FUNCTION my_func1 AS 'test.org.apache.spark.sql.MyDoubleAvg'")
>>> spark.catalog.getFunction("my_func1")
- Function(name='my_func1', catalog=None, namespace=['default'], ...
+ Function(name='my_func1', catalog=spark_catalog, namespace=['default'], ...
>>> spark.catalog.getFunction("default.my_func1")
- Function(name='my_func1', catalog=None, namespace=['default'], ...
+ Function(name='my_func1', catalog=spark_catalog, namespace=['default'], ...
Review Comment:
```suggestion
Function(name='my_func1', catalog='spark_catalog', namespace=['default'], ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org