You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 14:45:48 UTC

[GitHub] [arrow] paleolimbot commented on a diff in pull request #14550: ARROW-17301: [C++] Implement compute function "binary_slice"

paleolimbot commented on code in PR #14550:
URL: https://github.com/apache/arrow/pull/14550#discussion_r1021630921


##########
r/src/compute.cpp:
##########
@@ -449,7 +449,7 @@ std::shared_ptr<arrow::compute::FunctionOptions> make_compute_options(
     return std::make_shared<Options>(cpp11::as_cpp<std::string>(options["characters"]));
   }
 
-  if (func_name == "utf8_slice_codeunits") {
+  if (func_name == "utf8_slice_codeunits" || func_name == "binary_slice") {

Review Comment:
   Sorry I missed this ping on Thursday...I'm happy to do this but it's slightly easier to do on a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org