You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/29 06:00:39 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #818: Ftr: Add dubbo-go-cli telnet tool support
LaurenceLiZhixin opened a new pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
增加了dubbo-go的cli命令行工具，可以方便用户直连特定服务，发送包含特定参数的rpc请求，并展现结果。
目前依赖经过修改兼容的第三方hessian库。
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
**Special notes for your reviewer**:
支持嵌套struct，目前只支持单个参数的请求包和回包。
数据类型由于需要在json中定义，只支持golang基本数据类型：string、整形、浮点。
**Does this PR introduce a user-facing change?**:
NONE
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) (811f4f1) will **decrease** coverage by `3.79%`.
> The diff coverage is `54.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 63.75% 59.95% -3.80%
===========================================
Files 239 260 +21
Lines 12796 12781 -15
===========================================
- Hits 8158 7663 -495
- Misses 3849 4160 +311
- Partials 789 958 +169
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-19.38%)` | :arrow_down: |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (-0.13%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <ø> (-16.67%)` | :arrow_down: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (-7.08%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.94% <ø> (+1.35%)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `51.21% <ø> (-5.04%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `50.00% <ø> (-8.07%)` | :arrow_down: |
| [config\_center/base\_dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9iYXNlX2R5bmFtaWNfY29uZmlndXJhdGlvbi5nbw==) | `0.00% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (-2.50%)` | :arrow_down: |
| [config\_center/mock\_dynamic\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9tb2NrX2R5bmFtaWNfY29uZmlnLmdv) | `0.00% <ø> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [811f4f1...aebfe94](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-734165860
Now waiting for pr: https://github.com/apache/dubbo-go-hessian2/pull/243 to be merged.
Then I'll refer the latest hessian2 pkg and complete this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-766541021
have u finished ur work? if so, pls fix the github action failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-766541021
have u finished ur work? if so, pls fix the github action failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.85% 59.95% +0.09%
===========================================
Files 260 260
Lines 12854 12781 -73
===========================================
- Hits 7694 7663 -31
+ Misses 4199 4160 -39
+ Partials 961 958 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <0.00%> (-0.50%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.44% <0.00%> (+0.26%)` | :arrow_up: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `42.25% <0.00%> (+1.17%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `51.87% <0.00%> (+1.51%)` | :arrow_up: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `46.59% <0.00%> (+4.61%)` | :arrow_up: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `54.28% <0.00%> (+11.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [25ed35d...07754c0](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (8f7fc94) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) (811f4f1) will **decrease** coverage by `3.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 63.75% 60.02% -3.73%
===========================================
Files 239 260 +21
Lines 12796 12781 -15
===========================================
- Hits 8158 7672 -486
- Misses 3849 4150 +301
- Partials 789 959 +170
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-26.37%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `75.58% <0.00%> (-16.26%)` | :arrow_down: |
| [...a/service/remote/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvbWV0YWRhdGFfc2VydmljZV9wcm94eV9mYWN0b3J5Lmdv) | `25.00% <0.00%> (-15.00%)` | :arrow_down: |
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `60.00% <0.00%> (-11.43%)` | :arrow_down: |
| [...nstance/random/random\_service\_instance\_selector.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9pbnN0YW5jZS9yYW5kb20vcmFuZG9tX3NlcnZpY2VfaW5zdGFuY2Vfc2VsZWN0b3IuZ28=) | `55.55% <0.00%> (-11.12%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-11.05%)` | :arrow_down: |
| [metadata/identifier/service\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-bWV0YWRhdGEvaWRlbnRpZmllci9zZXJ2aWNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `20.00% <0.00%> (-10.77%)` | :arrow_down: |
| ... and [257 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [811f4f1...8f7fc94](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#discussion_r531686767
##########
File path: tools/cli/README.md
##########
@@ -0,0 +1,21 @@
+# dubbo-go-cli
+
+### 1. Problem we solved.
+
+For the running dubbo-go server, we need a telnet-cli tool to test if the server works healthily.
+The tool should support dubbo protocol, making it easy for you to define your own request pkg, get rsp struct of your server, and total costing time.
+
+
+### 2. How to get cli-tool
+run in dubbo-go/tools/cli \
+`$ sh build.sh`\
+and you can get dubbo-go-cli
+
+### 3. Quick start：[example](example/README_CN.md)
+
+
+
+### Third party dependence（temporary）
+
+github.com/LaurenceLiZhixin/dubbo-go-hessian2 \
Review comment:
why using ur branch?
##########
File path: tools/cli/README.md
##########
@@ -0,0 +1,21 @@
+# dubbo-go-cli
+
+### 1. Problem we solved.
+
+For the running dubbo-go server, we need a telnet-cli tool to test if the server works healthily.
+The tool should support dubbo protocol, making it easy for you to define your own request pkg, get rsp struct of your server, and total costing time.
+
+
+### 2. How to get cli-tool
+run in dubbo-go/tools/cli \
+`$ sh build.sh`\
+and you can get dubbo-go-cli
+
+### 3. Quick start：[example](example/README_CN.md)
+
+
+
+### Third party dependence（temporary）
+
+github.com/LaurenceLiZhixin/dubbo-go-hessian2 \
+github.com/LaurenceLiZhixin/json-interface-parser
Review comment:
pls submit ur code to github.com/dubbogo/gost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron merged pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
cityiron merged pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-768159075
I have finished my work.
> have u finished ur work? if so, pls fix the github action failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (8f7fc94) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) (811f4f1) will **decrease** coverage by `3.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 63.75% 59.89% -3.87%
===========================================
Files 239 260 +21
Lines 12796 12781 -15
===========================================
- Hits 8158 7655 -503
- Misses 3849 4168 +319
- Partials 789 958 +169
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-26.37%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-19.38%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `75.58% <0.00%> (-16.26%)` | :arrow_down: |
| [...a/service/remote/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvbWV0YWRhdGFfc2VydmljZV9wcm94eV9mYWN0b3J5Lmdv) | `25.00% <0.00%> (-15.00%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-12.65%)` | :arrow_down: |
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `60.00% <0.00%> (-11.43%)` | :arrow_down: |
| [...nstance/random/random\_service\_instance\_selector.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9pbnN0YW5jZS9yYW5kb20vcmFuZG9tX3NlcnZpY2VfaW5zdGFuY2Vfc2VsZWN0b3IuZ28=) | `55.55% <0.00%> (-11.12%)` | :arrow_down: |
| ... and [257 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [811f4f1...8f7fc94](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#discussion_r568478080
##########
File path: tools/cli/client/client.go
##########
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package client
+
+import (
+ "log"
+ "net"
+ "strconv"
+ "sync"
+ "time"
+)
+
+import (
+ "go.uber.org/atomic"
+)
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/common"
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+ _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
+)
+
+const defaultBufferSize = 1024 * 1024 * 4
Review comment:
add comment for this constant to let the reader know what is the meaning of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#discussion_r516430902
##########
File path: tools/cli/README.md
##########
@@ -0,0 +1,18 @@
+# dubbo-go-cli
+
+### 1. 解决问题
Review comment:
hey, guy, pls using English in an Apache project. Or u rename this file to readme_cn.md and add an English readme.
##########
File path: tools/cli/client/client.go
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package client
+
+import (
+ "bytes"
+ "fmt"
+ "log"
+ "net"
+ "sync"
+ "time"
+)
+
+import (
+ "go.uber.org/atomic"
+)
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/common"
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+ _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
+)
+
+const defaultBufferSize = 4096
+
+// TelnetClient maintain a connection to target
+type TelnetClient struct {
+ responseTimeout time.Duration
+ protocolName string
+ requestList []*protocol.Request
+ conn *net.TCPConn
+ proto protocol.Protocol
+
+ sequence atomic.Uint64
+ pendingResponses *sync.Map
+ waitNum atomic.Uint64
+}
+
+// NewTelnetClient create a new tcp connection, and create default request
+func NewTelnetClient(host string, port int, protocolName, interfaceID, version, group, method string, reqPkg interface{}) (*TelnetClient, error) {
+ tcpAddr := createTCPAddr(host, port)
+ resolved := resolveTCPAddr(tcpAddr)
+ conn, err := net.DialTCP("tcp", nil, resolved)
+ if err != nil {
+ return nil, err
+ }
+ log.Printf("connected to %s:%d!\n", host, port)
+ log.Printf("try calling interface:%s.%s\n", interfaceID, method)
+ log.Printf("with protocol:%s\n\n", protocolName)
+ proto := common.GetProtocol(protocolName)
+
+ return &TelnetClient{
+ conn: conn,
+ responseTimeout: 100000000, //default timeout
+ protocolName: protocolName,
+ pendingResponses: &sync.Map{},
+ proto: proto,
+ requestList: []*protocol.Request{
+ {
+ InterfaceID: interfaceID,
+ Version: version,
+ Method: method,
+ Group: group,
+ Params: []interface{}{reqPkg},
+ },
+ },
+ }, nil
+}
+
+func createTCPAddr(host string, port int) string {
+ var buffer bytes.Buffer
+ buffer.WriteString(host)
+ buffer.WriteByte(':')
+ buffer.WriteString(fmt.Sprintf("%d", port))
+ return buffer.String()
+}
+
+func resolveTCPAddr(addr string) *net.TCPAddr {
+ resolved, error := net.ResolveTCPAddr("tcp", addr)
+ if nil != error {
+ log.Fatalf("Error occured while resolving TCP address \"%v\": %v\n", addr, error)
+ }
+
+ return resolved
+}
+
+// ProcessRequests send all requests
+func (t *TelnetClient) ProcessRequests(userPkg interface{}) {
+ for i, _ := range t.requestList {
+ t.processSingleRequest(t.requestList[i], userPkg)
+ }
+}
+
+// addPendingResponse add a response @model to pending queue
+// once the rsp got, the model will be used.
+func (t *TelnetClient) addPendingResponse(model interface{}) uint64 {
+ seqId := t.sequence.Load()
+ t.pendingResponses.Store(seqId, model)
+ t.waitNum.Inc()
+ t.sequence.Inc()
+ return seqId
+}
+
+// removePendingResponse delete item from pending queue by @seq
+func (t *TelnetClient) removePendingResponse(seq uint64) {
+ if t.pendingResponses == nil {
+ return
+ }
+ if _, ok := t.pendingResponses.Load(seq); ok {
+ t.pendingResponses.Delete(seq)
+ t.waitNum.Dec()
+ }
+ return
+}
+
+// processSingleRequest call one req.
+func (t *TelnetClient) processSingleRequest(req *protocol.Request, userPkg interface{}) {
+ // proto create package procedure
+ req.ID = t.sequence.Load()
+ inputData, err := t.proto.Write(req)
+ if err != nil {
+ log.Fatalln("error: handler.Writer err = ", err)
+ }
+ startTime := time.Now()
+
+ // init rsp Package and add to pending queue
+ seqId := t.addPendingResponse(userPkg)
+ defer t.removePendingResponse(seqId)
+
+ requestDataChannel := make(chan []byte)
+ doneChannel := make(chan bool)
+ responseDataChannel := make(chan []byte)
Review comment:
the same as above
##########
File path: tools/cli/common/protocol.go
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package common
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+)
+
+var (
+ protocols = make(map[string]func() protocol.Protocol)
Review comment:
pls set its init length param, such as 8
##########
File path: tools/cli/client/client.go
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package client
+
+import (
+ "bytes"
+ "fmt"
+ "log"
+ "net"
+ "sync"
+ "time"
+)
+
+import (
+ "go.uber.org/atomic"
+)
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/common"
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+ _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
+)
+
+const defaultBufferSize = 4096
+
+// TelnetClient maintain a connection to target
+type TelnetClient struct {
+ responseTimeout time.Duration
+ protocolName string
+ requestList []*protocol.Request
+ conn *net.TCPConn
+ proto protocol.Protocol
+
+ sequence atomic.Uint64
+ pendingResponses *sync.Map
+ waitNum atomic.Uint64
+}
+
+// NewTelnetClient create a new tcp connection, and create default request
+func NewTelnetClient(host string, port int, protocolName, interfaceID, version, group, method string, reqPkg interface{}) (*TelnetClient, error) {
+ tcpAddr := createTCPAddr(host, port)
+ resolved := resolveTCPAddr(tcpAddr)
+ conn, err := net.DialTCP("tcp", nil, resolved)
+ if err != nil {
+ return nil, err
+ }
+ log.Printf("connected to %s:%d!\n", host, port)
+ log.Printf("try calling interface:%s.%s\n", interfaceID, method)
+ log.Printf("with protocol:%s\n\n", protocolName)
+ proto := common.GetProtocol(protocolName)
+
+ return &TelnetClient{
+ conn: conn,
+ responseTimeout: 100000000, //default timeout
+ protocolName: protocolName,
+ pendingResponses: &sync.Map{},
+ proto: proto,
+ requestList: []*protocol.Request{
+ {
+ InterfaceID: interfaceID,
+ Version: version,
+ Method: method,
+ Group: group,
+ Params: []interface{}{reqPkg},
+ },
+ },
+ }, nil
+}
+
+func createTCPAddr(host string, port int) string {
+ var buffer bytes.Buffer
+ buffer.WriteString(host)
+ buffer.WriteByte(':')
+ buffer.WriteString(fmt.Sprintf("%d", port))
+ return buffer.String()
+}
+
+func resolveTCPAddr(addr string) *net.TCPAddr {
+ resolved, error := net.ResolveTCPAddr("tcp", addr)
+ if nil != error {
+ log.Fatalf("Error occured while resolving TCP address \"%v\": %v\n", addr, error)
+ }
+
+ return resolved
+}
+
+// ProcessRequests send all requests
+func (t *TelnetClient) ProcessRequests(userPkg interface{}) {
+ for i, _ := range t.requestList {
+ t.processSingleRequest(t.requestList[i], userPkg)
+ }
+}
+
+// addPendingResponse add a response @model to pending queue
+// once the rsp got, the model will be used.
+func (t *TelnetClient) addPendingResponse(model interface{}) uint64 {
+ seqId := t.sequence.Load()
+ t.pendingResponses.Store(seqId, model)
+ t.waitNum.Inc()
+ t.sequence.Inc()
+ return seqId
+}
+
+// removePendingResponse delete item from pending queue by @seq
+func (t *TelnetClient) removePendingResponse(seq uint64) {
+ if t.pendingResponses == nil {
+ return
+ }
+ if _, ok := t.pendingResponses.Load(seq); ok {
+ t.pendingResponses.Delete(seq)
+ t.waitNum.Dec()
+ }
+ return
+}
+
+// processSingleRequest call one req.
+func (t *TelnetClient) processSingleRequest(req *protocol.Request, userPkg interface{}) {
+ // proto create package procedure
+ req.ID = t.sequence.Load()
+ inputData, err := t.proto.Write(req)
+ if err != nil {
+ log.Fatalln("error: handler.Writer err = ", err)
+ }
+ startTime := time.Now()
+
+ // init rsp Package and add to pending queue
+ seqId := t.addPendingResponse(userPkg)
+ defer t.removePendingResponse(seqId)
+
+ requestDataChannel := make(chan []byte)
Review comment:
do not need to set its length for this chan?
##########
File path: tools/cli/client/client.go
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package client
+
+import (
+ "bytes"
+ "fmt"
+ "log"
+ "net"
+ "sync"
+ "time"
+)
+
+import (
+ "go.uber.org/atomic"
+)
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/common"
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+ _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
+)
+
+const defaultBufferSize = 4096
+
+// TelnetClient maintain a connection to target
+type TelnetClient struct {
+ responseTimeout time.Duration
+ protocolName string
+ requestList []*protocol.Request
+ conn *net.TCPConn
+ proto protocol.Protocol
+
+ sequence atomic.Uint64
+ pendingResponses *sync.Map
+ waitNum atomic.Uint64
+}
+
+// NewTelnetClient create a new tcp connection, and create default request
+func NewTelnetClient(host string, port int, protocolName, interfaceID, version, group, method string, reqPkg interface{}) (*TelnetClient, error) {
+ tcpAddr := createTCPAddr(host, port)
+ resolved := resolveTCPAddr(tcpAddr)
+ conn, err := net.DialTCP("tcp", nil, resolved)
+ if err != nil {
+ return nil, err
+ }
+ log.Printf("connected to %s:%d!\n", host, port)
+ log.Printf("try calling interface:%s.%s\n", interfaceID, method)
+ log.Printf("with protocol:%s\n\n", protocolName)
+ proto := common.GetProtocol(protocolName)
+
+ return &TelnetClient{
+ conn: conn,
+ responseTimeout: 100000000, //default timeout
+ protocolName: protocolName,
+ pendingResponses: &sync.Map{},
+ proto: proto,
+ requestList: []*protocol.Request{
+ {
+ InterfaceID: interfaceID,
+ Version: version,
+ Method: method,
+ Group: group,
+ Params: []interface{}{reqPkg},
+ },
+ },
+ }, nil
+}
+
+func createTCPAddr(host string, port int) string {
Review comment:
pls using net.JoinHostPort instead.
##########
File path: tools/cli/example/README.md
##########
@@ -0,0 +1,132 @@
+# dubbo-go-cli 使用示例
Review comment:
the same as above readme. pls rename this file to readme_cn.md and add an english readme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (18ab1c4) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #818 +/- ##
==========================================
+ Coverage 59.45% 59.46% +0.01%
==========================================
Files 261 261
Lines 12950 12973 +23
==========================================
+ Hits 7700 7715 +15
- Misses 4276 4282 +6
- Partials 974 976 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `73.49% <0.00%> (-2.41%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `48.14% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `39.79% <0.00%> (-1.30%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.08% <0.00%> (-0.22%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `60.89% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.12% <0.00%> (+2.19%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.00% <0.00%> (+2.94%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (+8.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [17c4a9e...18ab1c4](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.85% 59.95% +0.09%
===========================================
Files 260 260
Lines 12854 12781 -73
===========================================
- Hits 7694 7663 -31
+ Misses 4199 4160 -39
+ Partials 961 958 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <0.00%> (-0.50%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.44% <0.00%> (+0.26%)` | :arrow_up: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `42.25% <0.00%> (+1.17%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `51.87% <0.00%> (+1.51%)` | :arrow_up: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `46.59% <0.00%> (+4.61%)` | :arrow_up: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `54.28% <0.00%> (+11.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [25ed35d...1599fd4](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-742989544
I'm waiting for gost v1.9.10, so as to make it build it successfully. Now is 1.9.9 and is not supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (f3ef409) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 59.45% 59.43% -0.03%
===========================================
Files 261 261
Lines 12950 12950
===========================================
- Hits 7700 7697 -3
- Misses 4276 4278 +2
- Partials 974 975 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `48.57% <0.00%> (-2.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `74.72% <0.00%> (-2.20%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (+8.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [17c4a9e...f3ef409](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-745816472
This pr can be merged only if pr #879 merged.
So, justing waiting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/374a01a37d527067383664ee26088a870bbeaf5d?el=desc) (374a01a) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.59% 59.95% +0.36%
===========================================
Files 261 260 -1
Lines 12903 12781 -122
===========================================
- Hits 7689 7663 -26
+ Misses 4243 4160 -83
+ Partials 971 958 -13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [remoting/getty/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `77.27% <0.00%> (-12.21%)` | :arrow_down: |
| [...nthesizer/rest/rest\_subscribed\_urls\_synthesizer.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zeW50aGVzaXplci9yZXN0L3Jlc3Rfc3Vic2NyaWJlZF91cmxzX3N5bnRoZXNpemVyLmdv) | `81.25% <0.00%> (-11.61%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-8.62%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `47.36% <0.00%> (-5.27%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [374a01a...34289f4](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.85% 59.95% +0.09%
===========================================
Files 260 260
Lines 12854 12781 -73
===========================================
- Hits 7694 7663 -31
+ Misses 4199 4160 -39
+ Partials 961 958 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <0.00%> (-0.50%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.44% <0.00%> (+0.26%)` | :arrow_up: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `42.25% <0.00%> (+1.17%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `51.87% <0.00%> (+1.51%)` | :arrow_up: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `46.59% <0.00%> (+4.61%)` | :arrow_up: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `54.28% <0.00%> (+11.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [25ed35d...53db19c](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (18ab1c4) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #818 +/- ##
==========================================
+ Coverage 59.45% 59.46% +0.01%
==========================================
Files 261 261
Lines 12950 12973 +23
==========================================
+ Hits 7700 7715 +15
- Misses 4276 4282 +6
- Partials 974 976 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `73.49% <0.00%> (-2.41%)` | :arrow_down: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `48.14% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `39.79% <0.00%> (-1.30%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.08% <0.00%> (-0.22%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `60.89% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.12% <0.00%> (+2.19%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.00% <0.00%> (+2.94%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (+8.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [17c4a9e...18ab1c4](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/374a01a37d527067383664ee26088a870bbeaf5d?el=desc) (374a01a) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.59% 59.95% +0.36%
===========================================
Files 261 260 -1
Lines 12903 12781 -122
===========================================
- Hits 7689 7663 -26
+ Misses 4243 4160 -83
+ Partials 971 958 -13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [remoting/getty/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `77.27% <0.00%> (-12.21%)` | :arrow_down: |
| [...nthesizer/rest/rest\_subscribed\_urls\_synthesizer.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zeW50aGVzaXplci9yZXN0L3Jlc3Rfc3Vic2NyaWJlZF91cmxzX3N5bnRoZXNpemVyLmdv) | `81.25% <0.00%> (-11.61%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-8.62%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `47.36% <0.00%> (-5.27%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [374a01a...1ab564f](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/25ed35dbcf25569e8cd045ab95550690e4076403?el=desc) (25ed35d) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.85% 59.95% +0.09%
===========================================
Files 260 260
Lines 12854 12781 -73
===========================================
- Hits 7694 7663 -31
+ Misses 4199 4160 -39
+ Partials 961 958 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <0.00%> (-0.50%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.44% <0.00%> (+0.26%)` | :arrow_up: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `42.25% <0.00%> (+1.17%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `51.87% <0.00%> (+1.51%)` | :arrow_up: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `46.59% <0.00%> (+4.61%)` | :arrow_up: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `54.28% <0.00%> (+11.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [25ed35d...11fd33b](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (b1ef2dc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) (811f4f1) will **decrease** coverage by `3.64%`.
> The diff coverage is `53.47%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 63.75% 60.10% -3.65%
===========================================
Files 239 260 +21
Lines 12796 12795 -1
===========================================
- Hits 8158 7691 -467
- Misses 3849 4146 +297
- Partials 789 958 +169
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-11.05%)` | :arrow_down: |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (-0.13%)` | :arrow_down: |
| [cluster/router/tag/file.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL2ZpbGUuZ28=) | `76.19% <0.00%> (-0.74%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <ø> (-16.67%)` | :arrow_down: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-7.31%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.94% <ø> (+1.35%)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `51.21% <ø> (-5.04%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `50.00% <ø> (-8.07%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <ø> (+0.17%)` | :arrow_up: |
| [config/remote\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3JlbW90ZV9jb25maWcuZ28=) | `75.00% <ø> (+1.31%)` | :arrow_up: |
| ... and [337 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [811f4f1...8f7fc94](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **increase** coverage by `0.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.45% 59.95% +0.49%
===========================================
Files 261 260 -1
Lines 12950 12781 -169
===========================================
- Hits 7700 7663 -37
+ Misses 4276 4160 -116
+ Partials 974 958 -16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [remoting/getty/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `77.27% <0.00%> (-12.21%)` | :arrow_down: |
| [...nthesizer/rest/rest\_subscribed\_urls\_synthesizer.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zeW50aGVzaXplci9yZXN0L3Jlc3Rfc3Vic2NyaWJlZF91cmxzX3N5bnRoZXNpemVyLmdv) | `81.25% <0.00%> (-11.61%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-8.62%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `47.36% <0.00%> (-5.27%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `74.01% <0.00%> (-4.97%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [17c4a9e...f3ef409](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (b1ef2dc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) (811f4f1) will **decrease** coverage by `3.64%`.
> The diff coverage is `53.47%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 63.75% 60.10% -3.65%
===========================================
Files 239 260 +21
Lines 12796 12795 -1
===========================================
- Hits 8158 7691 -467
- Misses 3849 4146 +297
- Partials 789 958 +169
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-11.05%)` | :arrow_down: |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (-0.13%)` | :arrow_down: |
| [cluster/router/tag/file.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL2ZpbGUuZ28=) | `76.19% <0.00%> (-0.74%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <ø> (-16.67%)` | :arrow_down: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-7.31%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.94% <ø> (+1.35%)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `51.21% <ø> (-5.04%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `50.00% <ø> (-8.07%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <ø> (+0.17%)` | :arrow_up: |
| [config/remote\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL3JlbW90ZV9jb25maWcuZ28=) | `75.00% <ø> (+1.31%)` | :arrow_up: |
| ... and [337 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [811f4f1...34e0999](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-719870621
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=h1) Report
> Merging [#818](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=desc) (1a28a44) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/374a01a37d527067383664ee26088a870bbeaf5d?el=desc) (374a01a) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 59.59% 59.95% +0.36%
===========================================
Files 261 260 -1
Lines 12903 12781 -122
===========================================
- Hits 7689 7663 -26
+ Misses 4243 4160 -83
+ Partials 971 958 -13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [remoting/getty/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `44.44% <0.00%> (-12.70%)` | :arrow_down: |
| [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `77.27% <0.00%> (-12.21%)` | :arrow_down: |
| [...nthesizer/rest/rest\_subscribed\_urls\_synthesizer.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zeW50aGVzaXplci9yZXN0L3Jlc3Rfc3Vic2NyaWJlZF91cmxzX3N5bnRoZXNpemVyLmdv) | `81.25% <0.00%> (-11.61%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `28.57% <0.00%> (-11.43%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-8.62%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `47.36% <0.00%> (-5.27%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `9.85% <0.00%> (-5.26%)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/dubbo-go/pull/818/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=footer). Last update [374a01a...93168df](https://codecov.io/gh/apache/dubbo-go/pull/818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#discussion_r568478080
##########
File path: tools/cli/client/client.go
##########
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package client
+
+import (
+ "log"
+ "net"
+ "strconv"
+ "sync"
+ "time"
+)
+
+import (
+ "go.uber.org/atomic"
+)
+
+import (
+ "github.com/apache/dubbo-go/tools/cli/common"
+ "github.com/apache/dubbo-go/tools/cli/protocol"
+ _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
+)
+
+const defaultBufferSize = 1024 * 1024 * 4
Review comment:
add comment for this constant to let the reader know what is the meaning of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #818: Ftr: Add dubbo-go-cli telnet tool support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #818:
URL: https://github.com/apache/dubbo-go/pull/818#issuecomment-734756089
I fix the change of hessian pkg, and problems above. Now I think it's able to merge.
Reviewer can try example in Readme file, to check if it works as hoped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org