You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/03/20 15:19:43 UTC
[GitHub] [myfaces-tobago] henningn opened a new pull request #45: Bar custom
component
henningn opened a new pull request #45: Bar custom component
URL: https://github.com/apache/myfaces-tobago/pull/45
The event listener is defined in the constructor because changes on the DOM can trigger DOMContentLoaded events. In this case the event listener is registered twice. (See tobago-dropdown.ts)
I've create an CssClass enum and a readonly variable, to prevent misspelling. Is this best practise or should we use just strings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [myfaces-tobago] henningn merged pull request #45: Bar
custom component
Posted by "jfrm.maurel@gmail.com" <jf...@gmail.com>.
Hi,
Le 23/03/2020 à 17:30, GitBox a écrit :
> henningn merged pull request #45: Bar custom component
Just tested. It works great. Cool !
Thank you for this improvement.
Regards
--
Jean-François MAUREL
PIMECA
http://www.pimeca.com
[GitHub] [myfaces-tobago] henningn merged pull request #45: Bar custom
component
Posted by GitBox <gi...@apache.org>.
henningn merged pull request #45: Bar custom component
URL: https://github.com/apache/myfaces-tobago/pull/45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services