You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/10 16:07:42 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4679: Disable shrinking QCOW2 volumes

ravening opened a new pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679


   ### Description
   Since QCOW2 volumes cannot be resized to lower value in any case,
   just disable it in backend.
   
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634


   Hi all!
   Not so sure how to proceed on this. I spoke with @svenvogel and he confirmed that the SolidFire's volumes are kept in the DB in `QCOW2` format, but their actual format is RAW.  According to the code, this will affect the shrinking of So'slidfire volumes. The same is the case with our plugin (StorPool). Is it alright to revert this change until a better solution is proposed or somebody with this version of CS and Solidfire as primary storage to confirm the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-813307421


   Ping @ravening 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-786458443


   ping @ravening ^^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-814026898


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003


   @shwstppr @ravening Sound interesting but its breaks our actually functionality with storepool and solidfire storages. how about revert this change until we have another fix for that? at the moment there is no backward functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003


   @shwstppr @ravening Sound interesting but its breaks our actually functionality with storepool and solidfire storages. how about revert this change until we have another fix for that. at the moment there is no backward functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044


   @slavkap is it better to check format directly in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java` and raise an exception if resize isn't possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-814027342


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-814002349


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-813966380


   > Ping @ravening
   
   @rhtyd done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882504246


   Yes, this sounds OK. Thanks for the answer and the suggestion, @shwstppr!  :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634


   Hi all!
   Not so sure how to proceed on this. I spoke with @svenvogel and he confirmed that the SolidFire's volumes are kept in the DB in `QCOW2` format, but their actual format is RAW.  According to the code, this will affect the shrinking of Solidfire volumes. The same is the case with our plugin (StorPool). Is it alright to revert this change until a better solution is proposed or somebody with this version of CS and Solidfire as primary storage to confirm the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-813972905


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-813973648


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882597651


   Not sure but will be easier to test for you @slavkap. I'm happy if you can work on it else I can do it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003


   @shwstppr @ravening Sound interesting but its breaks our actually functionality with storepool and solidfire storages. how about revert this change until we have another fix for that. at the moment there is no backward functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882604585


   Thanks, @shwstppr. I will do the fix then :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044


   @slavkap is it better to check format directly in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java' and raise an exception if resize isn't possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-814468425


   <b>Trillian test result (tid-362)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38001 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4679-t362-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 74.97 | test_kubernetes_clusters.py
   test_01_migrate_VM_and_root_volume | `Error` | 68.14 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 52.08 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044


   @slavkap is it better to check format directly in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java` and raise an exception if resize isn't possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882553219


   @shwstppr, do you want to add a fix (because you propose it), or could I work on a fix for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634


   Hi all!
   Not so sure how to proceed on this. I spoke with @svenvogel and he confirmed that the SolidFire's volumes are kept in the DB in `QCOW2` format, but their actual format is RAW.  According to the code, this will affect the shrinking of Solidfire volumes. The same is the case with our plugin (StorPool). Is it alright to revert this change until a better solution is proposed or somebody with this version of CS and Solidfire as primary storage to confirm the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003


   @shwstppr @ravening Sound interesting but its breaks our actually functionality with StorPool and Solidfire storages. how about revert this change until we have another fix for that? at the moment there is no backward functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-781228018


   @ravening I think we can have this in 4.15.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882518003


   @shwstppr @ravening Sound interesting but its breaks our actually functionality with storepool and solidfire storages. how about revert this change until we have another fix for that. at the moment there is no backward functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap commented on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882503044


   @slavkap is it better to check format directly in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtResizeVolumeCommandWrapper.java` and raise an exception if resize isn't possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] slavkap edited a comment on pull request #4679: Disable shrinking QCOW2 volumes

Posted by GitBox <gi...@apache.org>.
slavkap edited a comment on pull request #4679:
URL: https://github.com/apache/cloudstack/pull/4679#issuecomment-882497634


   Hi all!
   Not so sure how to proceed on this. I spoke with @svenvogel and he confirmed that the SolidFire's volumes are kept in the DB in `QCOW2` format, but their actual format is RAW.  According to the code, this will affect the shrinking of Solidfire volumes. The same is the case with our plugin (StorPool). Is it alright to revert this change until a better solution is proposed or somebody with this version of CS and Solidfire as primary storage to confirm the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org