You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/13 22:32:00 UTC
[GitHub] brodybits commented on a change in pull request #549: Cherry picks
brodybits commented on a change in pull request #549: Cherry picks
URL: https://github.com/apache/cordova-android/pull/549#discussion_r233247934
##########
File path: bin/templates/cordova/lib/pluginHandlers.js
##########
@@ -44,11 +37,8 @@ var handlers = {
}
},
uninstall: function (obj, plugin, project, options) {
- var dest = path.join(obj.targetDir, path.basename(obj.src));
- if (options && options.android_studio === true) {
- dest = studioPathRemap(obj);
- }
+ var dest = getInstallDestination(obj);
Review comment:
Same comment as I made on line 31. Here is a much simpler change:
```diff
@@ -47,7 +47,7 @@ var handlers = {
var dest = path.join(obj.targetDir, path.basename(obj.src));
if (options && options.android_studio === true) {
- dest = studioPathRemap(obj);
+ dest = getInstallDestination(obj);
}
// TODO: Add Koltin extension to uninstall, since they are handled like Java files
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org