You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shale.apache.org by "Rahul Akolkar (JIRA)" <ji...@apache.org> on 2006/08/31 16:53:31 UTC
[jira] Created: (SHALE-267) Promote the best practice of avoiding
spaces in dialog state names
Promote the best practice of avoiding spaces in dialog state names
------------------------------------------------------------------
Key: SHALE-267
URL: http://issues.apache.org/struts/browse/SHALE-267
Project: Shale
Issue Type: Task
Components: Dialog
Affects Versions: 1.0.3
Reporter: Rahul Akolkar
Priority: Minor
More of a task reminder for myself.
Discussion thread:
http://www.nabble.com/-dialog--Name-attribute-best-practice-tf2166188.html
Summary (fallback in case archives link fails):
On 8/25/06, Craig McClanahan <cr...@apache.org> wrote:
> On 8/25/06, Rahul Akolkar <ra...@gmail.com> wrote:
> >
> > On 8/25/06, Craig McClanahan <cr...@apache.org> wrote:
> > > On 8/25/06, Rahul Akolkar <ra...@gmail.com> wrote:
> > > >
> > > > I would like to propose a best practice for the name attribute used in
> > > > various bits of the XML vocabulary for Shale dialogs that recommends
> > > > restricting these to alphanumeric characters (no spaces etc.)
> > >
> > >
> > > I suppose there's a technical reason for this ... I really like the
> > > readability of these if we can keep them and it was why I chose "name"
> > > instead of "id' for that attribute in the first place.
> > >
> > <snip/>
> >
> > Yes, the state IDs are meant to be IDREFs in space separated lists on
> > transition targets when the SCXML <parallel> element is used, where it
> > will be possible to have more than one transition target, as long as
> > the targets belong to the regions of the same parallel.
> >
> > Ofcourse, when using a space separated list, having spaces in
> > individual tokens will throw a wrench in the works.
>
>
> Yah, that makes sense. Go ahead and do the patch, and I'll apply it.
>
> -Rahul
>
>
> Craig
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SHALE-267) Promote the best practice of avoiding
spaces in dialog state names
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-267?page=all ]
Wendy Smoak resolved SHALE-267.
-------------------------------
Fix Version/s: 1.0.4-SNAPSHOT
Resolution: Fixed
URL: http://svn.apache.org/viewvc?rev=439525&view=rev
Log:
Per discussion on the dev list, make dialog and state names omit embedded spaces.
> Promote the best practice of avoiding spaces in dialog state names
> ------------------------------------------------------------------
>
> Key: SHALE-267
> URL: http://issues.apache.org/struts/browse/SHALE-267
> Project: Shale
> Issue Type: Task
> Components: Dialog
> Affects Versions: 1.0.3
> Reporter: Rahul Akolkar
> Priority: Minor
> Fix For: 1.0.4-SNAPSHOT
>
>
> More of a task reminder for myself.
> Discussion thread:
> http://www.nabble.com/-dialog--Name-attribute-best-practice-tf2166188.html
> Summary (fallback in case archives link fails):
> On 8/25/06, Craig McClanahan <cr...@apache.org> wrote:
> > On 8/25/06, Rahul Akolkar <ra...@gmail.com> wrote:
> > >
> > > On 8/25/06, Craig McClanahan <cr...@apache.org> wrote:
> > > > On 8/25/06, Rahul Akolkar <ra...@gmail.com> wrote:
> > > > >
> > > > > I would like to propose a best practice for the name attribute used in
> > > > > various bits of the XML vocabulary for Shale dialogs that recommends
> > > > > restricting these to alphanumeric characters (no spaces etc.)
> > > >
> > > >
> > > > I suppose there's a technical reason for this ... I really like the
> > > > readability of these if we can keep them and it was why I chose "name"
> > > > instead of "id' for that attribute in the first place.
> > > >
> > > <snip/>
> > >
> > > Yes, the state IDs are meant to be IDREFs in space separated lists on
> > > transition targets when the SCXML <parallel> element is used, where it
> > > will be possible to have more than one transition target, as long as
> > > the targets belong to the regions of the same parallel.
> > >
> > > Ofcourse, when using a space separated list, having spaces in
> > > individual tokens will throw a wrench in the works.
> >
> >
> > Yah, that makes sense. Go ahead and do the patch, and I'll apply it.
> >
> > -Rahul
> >
> >
> > Craig
> >
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira