You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 07:50:33 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32227: [SPARK-35132][BUILD][CORE] Upgrade netty-all to 4.1.63.Final
HyukjinKwon commented on a change in pull request #32227:
URL: https://github.com/apache/spark/pull/32227#discussion_r615617804
##########
File path: dev/deps/spark-deps-hadoop-2.7-hive-2.3
##########
@@ -191,7 +191,7 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-netty-all/4.1.51.Final//netty-all-4.1.51.Final.jar
+netty-all/4.1.51.Final//netty-all-4.1.63.Final.jar
Review comment:
Oh, yeah, and seems like we should do `./dev/test-dependencies.sh --replace-manifest`:
```diff
-netty-all/4.1.51.Final//netty-all-4.1.63.Final.jar
+netty-all/4.1.63.Final//netty-all-4.1.63.Final.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org