You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/04/23 23:29:30 UTC

Review Request: Adding more Granular Global Parameters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


Description
-------

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bug CLOUDSTACK-741.


Diffs
-----

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/ApiConstants.java e774ecc 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java c60af27 
  server/src/com/cloud/api/ApiDispatcher.java 925d90a 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
  setup/db/db/schema-410to420.sql 10cdbba 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

Posted by Harikrishna Patnala <ha...@citrix.com>.

> On April 28, 2013, 6:49 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 56
> > <https://reviews.apache.org/r/10740/diff/3/?file=284664#file284664line56>
> >
> >     Where is the actual change for this config in the code ? It should have been AlertManagerImpl I guess

Yes it's AlertManagerImpl and I have changed it while checking for alerts.


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19830
-----------------------------------------------------------


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19830
-----------------------------------------------------------



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/10740/#comment40905>

    Where is the actual change for this config in the code ? It should have been AlertManagerImpl I guess


- Nitin Mehta


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

Posted by Abhinandan Prateek <ap...@apache.org>.

> On April 29, 2013, 6:22 a.m., Abhinandan Prateek wrote:
> > Ship It!

The patch does not apply please resubmit.


- Abhinandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19847
-----------------------------------------------------------


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19847
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On April 26, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
-----------------------------------------------------------

(Updated April 29, 2013, 6:40 a.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


Changes
-------

updated patch.


Description
-------

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.


Diffs (updated)
-----

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
  api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
  setup/db/db/schema-410to420.sql 78444fd 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
-----------------------------------------------------------

(Updated April 26, 2013, 5:31 a.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


Changes
-------

updated patch with clear import statements.
import * was probably because of editor optimization. 


Description
-------

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.


Diffs (updated)
-----

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
  api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
  setup/db/db/schema-410to420.sql 78444fd 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

Posted by Prasanna Santhanam <ts...@apache.org>.
On Fri, Apr 26, 2013 at 04:54:45AM -0000, Sateesh Chodapuneedi wrote:
> api/src/com/cloud/configuration/ConfigurationService.java
> <https://reviews.apache.org/r/10740/#comment40757>
> 
>     Need to avoid * imports per coding guidelines.

Likely coming from the IDE auto importing. I had to fix this in Idea.
-- 
Prasanna.,

------------------------
Powered by BigRock.com

Re: Review Request: Adding more Granular Global Parameters

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19752
-----------------------------------------------------------



api/src/com/cloud/configuration/ConfigurationService.java
<https://reviews.apache.org/r/10740/#comment40757>

    Need to avoid * imports per coding guidelines.


- Sateesh Chodapuneedi


On April 26, 2013, 4:33 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 4:33 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 78444fd 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: Adding more Granular Global Parameters

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
-----------------------------------------------------------

(Updated April 26, 2013, 4:33 a.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


Description
-------

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198, CLOUDSTACK-2200, and CLOUDSTACK-741.


Diffs
-----

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
  api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
  setup/db/db/schema-410to420.sql 78444fd 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/
-----------------------------------------------------------

(Updated April 26, 2013, 3:37 a.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


Changes
-------

Updated patch after changing scopeid/scopename to zoneid/clusterid/accountid/storagepoolid
Added fixes for the bugs CLOUDSTACK-2176, CLOUDSTACK-2198.


Description
-------

CLOUDSTACK-741: Granular Global Parameters
Adding the zone, cluster, account level parameters:
zone: network.throttling.rate, Guest Domain Prefix
cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
account:  allow.public.user.templates, remote.access.vpn.client.iprange  


This addresses bugs CLOUDSTACK-2176, CLOUDSTACK-2198 and CLOUDSTACK-741.


Diffs (updated)
-----

  api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
  api/src/com/cloud/network/NetworkModel.java 4d7d714 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
  api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 176c47a 
  server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
  server/src/com/cloud/api/ApiDBUtils.java 21ce63b 
  server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
  server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
  server/src/com/cloud/configuration/Config.java dbcbc53 
  server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
  server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
  server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
  server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
  server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
  server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
  server/src/com/cloud/server/ManagementServerImpl.java 16127a2 
  server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
  server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
  server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
  server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
  server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
  server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
  server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
  setup/db/db/schema-410to420.sql 78444fd 
  test/integration/smoke/test_global_settings.py 12b35d7 

Diff: https://reviews.apache.org/r/10740/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10740/#review19701
-----------------------------------------------------------


Can you resubmit the patch after changing scope_id/scope_name to zone_id, account_id, cluster_id etc .

- Abhinandan Prateek


On April 23, 2013, 9:29 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10740/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 9:29 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> Adding the zone, cluster, account level parameters:
> zone: network.throttling.rate, Guest Domain Prefix
> cluster: cluster.cpu.allocated.capacity.disablethreshold, cluster.cpu.allocated.capacity.notificationthreshold, cluster.memory.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.notificationthreshold
> account:  allow.public.user.templates, remote.access.vpn.client.iprange  
> 
> 
> This addresses bug CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/configuration/ConfigurationService.java 6937d0b 
>   api/src/com/cloud/network/NetworkModel.java 4d7d714 
>   api/src/org/apache/cloudstack/api/ApiConstants.java e774ecc 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 9f34405 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 074c5a3 
>   server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 
>   server/src/com/cloud/api/ApiDBUtils.java c60af27 
>   server/src/com/cloud/api/ApiDispatcher.java 925d90a 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 
>   server/src/com/cloud/configuration/Config.java dbcbc53 
>   server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 
>   server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 
>   server/src/com/cloud/network/NetworkModelImpl.java c5930d9 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 
>   server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a 
>   server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e 
>   server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 
>   server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 
>   server/test/com/cloud/network/MockNetworkModelImpl.java 511249f 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 
>   server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 
>   server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java fb29469 
>   server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java f1163ef 
>   setup/db/db/schema-410to420.sql 10cdbba 
>   test/integration/smoke/test_global_settings.py 12b35d7 
> 
> Diff: https://reviews.apache.org/r/10740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>