You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 20:09:42 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
nealrichardson opened a new pull request #7929:
URL: https://github.com/apache/arrow/pull/7929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468419449
##########
File path: r/tools/linuxlibs.R
##########
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <- Sys.which("cmake")
- if (!nzchar(cmake) || cmake_version() < 3.2) {
+ cmake <- find_cmake(c(
+ Sys.getenv("CMAKE"),
+ Sys.which("cmake"),
+ Sys.which("cmake3")
+ ))
+
+ if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.16.2")
Review comment:
You probably want to bump that version: latest is either 3.18.1, 3.17.4 or 3.16.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #7929:
URL: https://github.com/apache/arrow/pull/7929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468418886
##########
File path: r/tools/linuxlibs.R
##########
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <- Sys.which("cmake")
- if (!nzchar(cmake) || cmake_version() < 3.2) {
+ cmake <- find_cmake(c(
+ Sys.getenv("CMAKE"),
+ Sys.which("cmake"),
+ Sys.which("cmake3")
Review comment:
Does `cmake3` actually exist in the wild?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468620814
##########
File path: r/tools/linuxlibs.R
##########
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <- Sys.which("cmake")
- if (!nzchar(cmake) || cmake_version() < 3.2) {
+ cmake <- find_cmake(c(
+ Sys.getenv("CMAKE"),
+ Sys.which("cmake"),
+ Sys.which("cmake3")
Review comment:
Apparently so; it was in the report on https://issues.apache.org/jira/browse/ARROW-9602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468626923
##########
File path: r/tools/linuxlibs.R
##########
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
}
ensure_cmake <- function() {
- cmake <- Sys.which("cmake")
- if (!nzchar(cmake) || cmake_version() < 3.2) {
+ cmake <- find_cmake(c(
+ Sys.getenv("CMAKE"),
+ Sys.which("cmake"),
+ Sys.which("cmake3")
+ ))
+
+ if (is.null(cmake)) {
# If not found, download it
cat("**** cmake\n")
CMAKE_VERSION <- Sys.getenv("CMAKE_VERSION", "3.16.2")
Review comment:
Right, will do. Can't remember where I got that version number from before--probably one of our CI jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#issuecomment-671569652
https://issues.apache.org/jira/browse/ARROW-9602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org