You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/03/13 20:34:26 UTC
[PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
viirya opened a new pull request, #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #190.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#discussion_r1525075262
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -439,8 +440,29 @@ case class CometScanExec(
object CometScanExec {
Review Comment:
perhaps we can also consider `CometScanExec extends TreeNode` to remove `mapProductIterator` method copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#discussion_r1525196624
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -439,8 +440,29 @@ case class CometScanExec(
object CometScanExec {
Review Comment:
We want to run `mapProductIterator` on `FileSourceScanExec`. I'm not sure how `object CometScanExec extends TreeNode` can help us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#issuecomment-1997931138
This patch cannot completely resolve the ticket #190 but only fixes the first error. After the first error is fixed, there comes out another API incompatibility issue around `DataSourceScanExec`.
I think it is still good to have this patch to fix the first error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya merged PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#issuecomment-1995992578
> mapProductIterator in class TreeNode cannot be accessed in org.apache.spark.sql.execution.FileSourceScanExec
Ah, `mapProductIterator` is protected method. Let me update this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#discussion_r1525308786
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -439,8 +440,29 @@ case class CometScanExec(
object CometScanExec {
Review Comment:
You are right, its needed to run `mapProductIterator` on `FileSourceScanExec`, I wrongly assumed this method needed for `CometScanExec `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#issuecomment-1998319475
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Use `makeCopy` to change relation in `FileSourceScanExec` [arrow-datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #207:
URL: https://github.com/apache/arrow-datafusion-comet/pull/207#issuecomment-1996065796
## [Codecov](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/207?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `84.61538%` with `2 lines` in your changes are missing coverage. Please review.
> :exclamation: No coverage uploaded for pull request base (`main@9aa42cd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit).
| [Files](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/207?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ala/org/apache/spark/sql/comet/CometScanExec.scala](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRTY2FuRXhlYy5zY2FsYQ==) | 84.61% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage ? 33.33%
Complexity ? 769
=======================================
Files ? 107
Lines ? 35406
Branches ? 7673
=======================================
Hits ? 11804
Misses ? 21147
Partials ? 2455
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/207?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org