You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/28 10:43:46 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #583: [YUNIKORN-1833] Rationalize event verification in partition_test.go
pbacsko opened a new pull request, #583:
URL: https://github.com/apache/yunikorn-core/pull/583
### What is this PR for?
Remove event verification from `partition_test.go`, it's difficult to conveniently check them in those tests.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1833
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #583: [YUNIKORN-1833] Rationalize event verification in partition_test.go
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #583:
URL: https://github.com/apache/yunikorn-core/pull/583#issuecomment-1611182921
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#583](https://app.codecov.io/gh/apache/yunikorn-core/pull/583?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (abf8807) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/530533f78bdcc733d3075b6ff41bea2e8d999b80?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (530533f) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head abf8807 differs from pull request most recent head 12a2395. Consider uploading reports for the commit 12a2395 to get more accurate results
```diff
@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 74 74
Lines 12209 12209
=======================================
Hits 9329 9329
Misses 2569 2569
Partials 311 311
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #583: [YUNIKORN-1833] Rationalize event verification in partition_test.go
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #583: [YUNIKORN-1833] Rationalize event verification in partition_test.go
URL: https://github.com/apache/yunikorn-core/pull/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org