You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2026/10/06 18:59:45 UTC
[PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
rzo1 opened a new pull request, #1423:
URL: https://github.com/apache/opennlp/pull/1423
Corrects opennlp-api Javadoc that made inaccurate claims about return values, copying and allocation, and drops design history and implementation commentary. Adds missing @since tags and links to the cited literature, including the lattice tokenizer classes in opennlp-runtime. Only Javadoc and comments change; there is no behavior change.
Fixes #1416.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #1423:
URL: https://github.com/apache/opennlp/pull/1423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #1423:
URL: https://github.com/apache/opennlp/pull/1423#discussion_r4204401694
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeWhitespace.java:
##########
@@ -31,14 +31,18 @@
* for whitespace but carry {@code White_Space=no} (zero-width and other format characters).
* The data mirrors the tables in
* <a href="https://en.wikipedia.org/wiki/Whitespace_character">Whitespace character</a>
- * and the Unicode Character Database ({@code PropList.txt}).</p>
+ * and the Unicode Character Database
+ * (<a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
see above. IMHO needs to mention the baseline used to create this class since we do **not** bundle PropList.txt in OpenNLP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on code in PR #1423:
URL: https://github.com/apache/opennlp/pull/1423#discussion_r4204345469
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeDash.java:
##########
@@ -27,11 +27,12 @@
* Reference data for Unicode dashes, plus O(1) membership lookups.
*
* <p>This is a static, immutable table of every code point that carries the Unicode {@code Dash}
- * property (Unicode Character Database, {@code PropList.txt}). The set is broader than the
- * {@code Pd} (dash punctuation) general category: it also includes the swung dash ({@code Po})
- * and the mathematical minus signs ({@code Sm}). Java offers no {@code Dash} predicate and
- * {@code \p{Pd}} would miss the {@code Sm} and {@code Po} members, which is why the set is kept
- * here explicitly.</p>
+ * property (Unicode Character Database,
+ * <a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
C/Should we reference version 17 of that list? We had agreed - some weeks ago - on not introducing a mix of versions (18 vs. 17) and stayed with 17 elsewhere. Thus, for consistency, it feels odd to reference 17 here. Please check / comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on code in PR #1423:
URL: https://github.com/apache/opennlp/pull/1423#discussion_r4204348661
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeWhitespace.java:
##########
@@ -31,14 +31,18 @@
* for whitespace but carry {@code White_Space=no} (zero-width and other format characters).
* The data mirrors the tables in
* <a href="https://en.wikipedia.org/wiki/Whitespace_character">Whitespace character</a>
- * and the Unicode Character Database ({@code PropList.txt}).</p>
+ * and the Unicode Character Database
+ * (<a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
See previous comment on 16 vs. 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #1423:
URL: https://github.com/apache/opennlp/pull/1423#discussion_r4204395955
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeDash.java:
##########
@@ -27,11 +27,12 @@
* Reference data for Unicode dashes, plus O(1) membership lookups.
*
* <p>This is a static, immutable table of every code point that carries the Unicode {@code Dash}
- * property (Unicode Character Database, {@code PropList.txt}). The set is broader than the
- * {@code Pd} (dash punctuation) general category: it also includes the swung dash ({@code Po})
- * and the mathematical minus signs ({@code Sm}). Java offers no {@code Dash} predicate and
- * {@code \p{Pd}} would miss the {@code Sm} and {@code Po} members, which is why the set is kept
- * here explicitly.</p>
+ * property (Unicode Character Database,
+ * <a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
@krickert which version was used to create the mappings here? I think we should mention the version used to create this class, so we can update to newer ones (since the txt file is not shipped inside OpenNLP).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1416: Correct and trim opennlp-api Javadoc (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #1423:
URL: https://github.com/apache/opennlp/pull/1423#discussion_r4216595225
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeWhitespace.java:
##########
@@ -31,14 +31,18 @@
* for whitespace but carry {@code White_Space=no} (zero-width and other format characters).
* The data mirrors the tables in
* <a href="https://en.wikipedia.org/wiki/Whitespace_character">Whitespace character</a>
- * and the Unicode Character Database ({@code PropList.txt}).</p>
+ * and the Unicode Character Database
+ * (<a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
@krickert Told me 17 via slack. Will fix.
##########
opennlp-api/src/main/java/opennlp/tools/util/normalizer/UnicodeDash.java:
##########
@@ -27,11 +27,12 @@
* Reference data for Unicode dashes, plus O(1) membership lookups.
*
* <p>This is a static, immutable table of every code point that carries the Unicode {@code Dash}
- * property (Unicode Character Database, {@code PropList.txt}). The set is broader than the
- * {@code Pd} (dash punctuation) general category: it also includes the swung dash ({@code Po})
- * and the mathematical minus signs ({@code Sm}). Java offers no {@code Dash} predicate and
- * {@code \p{Pd}} would miss the {@code Sm} and {@code Po} members, which is why the set is kept
- * here explicitly.</p>
+ * property (Unicode Character Database,
+ * <a href="https://www.unicode.org/Public/16.0.0/ucd/PropList.txt">{@code PropList.txt}</a>,
Review Comment:
@krickert Told me 17 via slack. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org