You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "adrianiacobghiula (via GitHub)" <gi...@apache.org> on 2026/05/08 07:43:06 UTC
[PR] fix: add batchIdx to messageID.String() when batched message [pulsar-client-go]
adrianiacobghiula opened a new pull request, #1491:
URL: https://github.com/apache/pulsar-client-go/pull/1491
### Motivation
MessageID contains a batchIdx that is being skipped on String(), adding the same functionality as in java - BatchMessageIdImpl overrides the toString() to add the batchId
### Modifications
add batchIdx if > -1
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
- *Extended unit test*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add batchIdx to messageID.String() when batched message [pulsar-client-go]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #1491:
URL: https://github.com/apache/pulsar-client-go/pull/1491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add batchIdx to messageID.String() when batched message [pulsar-client-go]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #1491:
URL: https://github.com/apache/pulsar-client-go/pull/1491#issuecomment-4415249965
@adrianiacobghiula Good work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add batchIdx to messageID.String() when batched message [pulsar-client-go]
Posted by "adrianiacobghiula (via GitHub)" <gi...@apache.org>.
adrianiacobghiula commented on PR #1491:
URL: https://github.com/apache/pulsar-client-go/pull/1491#issuecomment-4414462810
@nodece I fixed the broken integration test -> you can check first the execution on my repo https://github.com/adrianiacobghiula/pulsar-client-go/actions/runs/25611371370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org