You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/10/14 01:09:31 UTC
[jira] Created: (HDFS-703) Replace current fault injection
implementation with one from Common
Replace current fault injection implementation with one from Common
-------------------------------------------------------------------
Key: HDFS-703
URL: https://issues.apache.org/jira/browse/HDFS-703
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 0.22.0
Reporter: Konstantin Boudnik
After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-703:
------------------------------------
Attachment: HDFS-703.patch
Synch'ed with trunk
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774324#action_12774324 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
Well, the point of having this file as external was exactly to avoid checking it in. Our build system has too many build code duplication all over the place. I didn't want to increase the amount of duplicated code by adding a relatively big chunk of exactly same xml into three different classes.
We already have the same SVN-git synchronization problem with test-patch script. I see two ways of solving this problem:
- have the svn:externals represented by symlinks in git repo (there are ready solutions for this)
- checkin files represented by svn:externals into git repositories (might have some strange side effects, I think)
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775224#action_12775224 ]
Hudson commented on HDFS-703:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/])
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-703:
---------------------------------------
Assignee: Konstantin Boudnik
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773648#action_12773648 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
Here's what I've just did:
{noformat}
% svn co https://svn.apache.org/repos/asf/hadoop/hdfs/trunk new-hdfs-workspace
...
Fetching external item into '123/src/test/aop/build'
A new-hdfs-workspace/src/test/aop/build/aop.xml
Checked out external at revision 832876.
...
{noformat}
As you can see the referred {{aop.xml}} file is imported from Common project through svn:externals
{noformat}
% cd new-hdfs-workspace
% ls -l src/test/aop/build
aop.xml
% ant injectfaults
...
compile-fault-inject:
[echo] Start weaving aspects in place
[echo] Weaving of aspects is finished
BUILD SUCCESSFUL
Total time: 1 minute 11 seconds
{noformat}
So everything seems to be working properly. Hope it helps to resolve the issue.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773601#action_12773601 ]
Eli Collins commented on HDFS-703:
----------------------------------
I'm getting a build failure running ant binary on a clean hdfs tree, this change makes build.xml reference test/aop/build/aop.xml but that file isn't checked in or generated first. Any ideas?
BUILD FAILED
/home/eli/src/apache-hadoop-hdfs/build.xml:262: Cannot find /home/eli/src/apache-hadoop-hdfs/src/test/aop/build/aop.xml imported from /home/eli/src/apache-hadoop-hdfs/build.xml
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik resolved HDFS-703.
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Thanks for the review, Nicholas.
I've just committed this.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773215#action_12773215 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
I have executed variety of FI related target with this patch and everything seems to be working. Also, I have created instrumented jar files before and after the patch's application. They are the same. So, the patch is good to go, it seems.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774341#action_12774341 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
Well, mine too :-) Glad everything is back to normal again. Thanks all for the patience.
As for code divergence: I really hope we'd be able to switch to Maven some day which will address some of these issues.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-703:
----------------------------------------
Component/s: build
Hadoop Flags: [Reviewed]
+1
Tried the patch. It worked well.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774169#action_12774169 ]
Eli Collins commented on HDFS-703:
----------------------------------
Hey Konstantin,
Can we check that file in? I don't use svn and so can't build if I sync past this change.
Thanks,
Eli
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773262#action_12773262 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
And this one doesn't need to be backported to 0.21 branch, for its implementation is Ok as it is - it should server the purpose.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774353#action_12774353 ]
Hudson commented on HDFS-703:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #98 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/98/])
. Removing svn external and adding build/aop.xml file physically to fix incompatibility with git (cos)
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-703:
------------------------------------
Attachment: HDFS-703.patch
Synch'ed with HADOOP-6347 implementation.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777203#action_12777203 ]
Hudson commented on HDFS-703:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/])
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774330#action_12774330 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
Ok, I've removed the svn:externals from the directory in question and have checked-in the build/aop.xml file physically. It will fix the git problem.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773608#action_12773608 ]
Eli Collins commented on HDFS-703:
----------------------------------
Building at the previous change trunk@832540 works.
Btw commenting out the include in build.xml results in:
BUILD FAILED
Target "injectfaults" does not exist in the project "Hadoop-Hdfs". It is used from target "jar-hdfs-test-fault-inject".
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-703:
------------------------------------
Attachment: HDFS-703.patch
Initial patch
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774337#action_12774337 ]
Todd Lipcon commented on HDFS-703:
----------------------------------
I agree the code duplication is annoying, but post-split I think it makes sense. If common makes a change, we expect them to test it in common but might not notice if the change breaks mapreduce and HDFS. Down the line the build processes might diverge more, in which case having separate copies is good.
Thanks for checking in the file. My trunk builds again :)
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775405#action_12775405 ]
Hudson commented on HDFS-703:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #136 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/])
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773283#action_12773283 ]
Hudson commented on HDFS-703:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #97 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/97/])
. Replace current fault injection implementation with one from. Contributed by Konstantin Boudnik
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774325#action_12774325 ]
Konstantin Boudnik commented on HDFS-703:
-----------------------------------------
If svn:externals seems to be an inappropriate - I don't like them myself :-( - I can simply checkin this file into all subprojects, which is ugly too but at least will allow to keep the injection stuff encapsulated.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-703) Replace current fault injection
implementation with one from Common
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774168#action_12774168 ]
Todd Lipcon commented on HDFS-703:
----------------------------------
This breaks the build for those of us using git-svn (or the git.apache.org mirror). This seems like a complete blocker - most of the hadoop developers I've spoken with use git-svn for their working trees.
Would like to propose this be reverted, or the file duplicated into the local tree.
> Replace current fault injection implementation with one from Common
> -------------------------------------------------------------------
>
> Key: HDFS-703
> URL: https://issues.apache.org/jira/browse/HDFS-703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-703.patch, HDFS-703.patch, HDFS-703.patch
>
>
> After HADOOP-6204 has been implemented HDFS doesn't need to have its separate implementation of fault injection framework. Instead it has to reuse one from Common.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.