You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/12/20 11:30:49 UTC
[PR] Document the missing website permission [airflow]
pankajastro opened a new pull request, #36329:
URL: https://github.com/apache/airflow/pull/36329
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document the missing website permission [airflow]
Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro merged PR #36329:
URL: https://github.com/apache/airflow/pull/36329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document the missing website permission [airflow]
Posted by "aliotta (via GitHub)" <gi...@apache.org>.
aliotta commented on code in PR #36329:
URL: https://github.com/apache/airflow/pull/36329#discussion_r1434387551
##########
docs/apache-airflow-providers-fab/auth-manager/access-control.rst:
##########
@@ -196,19 +200,28 @@ Website Permissions
Action Permissions Minimum Role
====================================== ======================================================================= ============
Access homepage Website.can_read Viewer
+Show Browse menu Browse.menu_access Viewer
+Show DAGs menu DAGs.menu_access Viewer
Get DAG stats DAGs.can_read, DAG Runs.can_read Viewer
+Show Task Instances menu Task Instances.menu_access Viewer
Get Task stats DAGs.can_read, DAG Runs.can_read, Task Instances.can_read Viewer
Get last DAG runs DAGs.can_read, DAG Runs.can_read Viewer
Get DAG code DAGs.can_read, DAG Code.can_read Viewer
Get DAG details DAGs.can_read, DAG Runs.can_read Viewer
+Show DAG Dependencies menu DAG Dependencies menu Viewer
+Get DAG Dependencies DAG Dependencies.can_read Viewer
Get rendered DAG DAGs.can_read, Task Instances.can_read Viewer
Get Logs with metadata DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Get Log DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Redirect to external Log DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Get Task DAGs.can_read, Task Instances.can_read Viewer
+Show XCom menu XComs.menu_access Op
Get XCom DAGs.can_read, Task Instances.can_read, XComs.can_read Viewer
+Create XCom XComs.can_create Op #TODO
Review Comment:
whats the TODO here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document the missing website permission [airflow]
Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on code in PR #36329:
URL: https://github.com/apache/airflow/pull/36329#discussion_r1434798051
##########
docs/apache-airflow-providers-fab/auth-manager/access-control.rst:
##########
@@ -196,19 +200,28 @@ Website Permissions
Action Permissions Minimum Role
====================================== ======================================================================= ============
Access homepage Website.can_read Viewer
+Show Browse menu Browse.menu_access Viewer
+Show DAGs menu DAGs.menu_access Viewer
Get DAG stats DAGs.can_read, DAG Runs.can_read Viewer
+Show Task Instances menu Task Instances.menu_access Viewer
Get Task stats DAGs.can_read, DAG Runs.can_read, Task Instances.can_read Viewer
Get last DAG runs DAGs.can_read, DAG Runs.can_read Viewer
Get DAG code DAGs.can_read, DAG Code.can_read Viewer
Get DAG details DAGs.can_read, DAG Runs.can_read Viewer
+Show DAG Dependencies menu DAG Dependencies menu Viewer
+Get DAG Dependencies DAG Dependencies.can_read Viewer
Get rendered DAG DAGs.can_read, Task Instances.can_read Viewer
Get Logs with metadata DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Get Log DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Redirect to external Log DAGs.can_read, Task Instances.can_read, Task Logs.can_read Viewer
Get Task DAGs.can_read, Task Instances.can_read Viewer
+Show XCom menu XComs.menu_access Op
Get XCom DAGs.can_read, Task Instances.can_read, XComs.can_read Viewer
+Create XCom XComs.can_create Op #TODO
Review Comment:
removed. this was unintended. thanks for pointing out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document the missing website permission [airflow]
Posted by "aliotta (via GitHub)" <gi...@apache.org>.
aliotta commented on code in PR #36329:
URL: https://github.com/apache/airflow/pull/36329#discussion_r1434383648
##########
docs/apache-airflow-providers-fab/auth-manager/access-control.rst:
##########
@@ -228,19 +241,50 @@ Toggle DAG paused status DAGs.can_edit
Show Gantt Chart DAGs.can_read, Task Instances.can_read Viewer
Get external links DAGs.can_read, Task Instances.can_read Viewer
Show Task Instances DAGs.can_read, Task Instances.can_read Viewer
+Show Configurations menu Configurations.menu_access Op
Show Configs Configurations.can_read Viewer
Delete multiple records DAGs.can_edit User
Set Task Instance as running DAGs.can_edit User
Set Task Instance as failed DAGs.can_edit User
Set Task Instance as success DAGs.can_edit User
Set Task Instance as up_for_retry DAGs.can_edit User
Autocomplete DAGs.can_read Viewer
+Show Dataset menu Datasets.menu_access Viewer
+Show Datasets Datasets.can_read Viewer
+Show Docs menu Docs.menu_access Viewer
+Show Documentation menu Documentation.menu_access Viewer
+Show Jobs menu Jobs.menu_access Viewer
+Show Audit Log Audit Logs.menu_access Viewer
+Reset Password My Password.can_read, My Password.can_edit Viewer Viewer
Review Comment:
I think you have one too many "Viewer" here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document the missing website permission [airflow]
Posted by "aliotta (via GitHub)" <gi...@apache.org>.
aliotta commented on code in PR #36329:
URL: https://github.com/apache/airflow/pull/36329#discussion_r1434385701
##########
docs/apache-airflow-providers-fab/auth-manager/access-control.rst:
##########
@@ -196,19 +200,28 @@ Website Permissions
Action Permissions Minimum Role
====================================== ======================================================================= ============
Access homepage Website.can_read Viewer
+Show Browse menu Browse.menu_access Viewer
+Show DAGs menu DAGs.menu_access Viewer
Get DAG stats DAGs.can_read, DAG Runs.can_read Viewer
+Show Task Instances menu Task Instances.menu_access Viewer
Get Task stats DAGs.can_read, DAG Runs.can_read, Task Instances.can_read Viewer
Get last DAG runs DAGs.can_read, DAG Runs.can_read Viewer
Get DAG code DAGs.can_read, DAG Code.can_read Viewer
Get DAG details DAGs.can_read, DAG Runs.can_read Viewer
+Show DAG Dependencies menu DAG Dependencies menu Viewer
Review Comment:
should the second column be DAG Dependencies.menu_access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org