You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2024/02/15 15:04:45 UTC
[PR] docs: Update cmake documentation for experimental plugins. [trafficserver]
brbzull0 opened a new pull request, #11078:
URL: https://github.com/apache/trafficserver/pull/11078
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Update cmake documentation for experimental plugins. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #11078:
URL: https://github.com/apache/trafficserver/pull/11078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Update cmake documentation for experimental plugins. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11078:
URL: https://github.com/apache/trafficserver/pull/11078#issuecomment-1973315554
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Update cmake documentation for experimental plugins. [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #11078:
URL: https://github.com/apache/trafficserver/pull/11078#discussion_r1503604381
##########
doc/developer-guide/plugins/example-plugins/index.en.rst:
##########
@@ -48,9 +48,9 @@ understand the following topics:
- Working with HTTP header functions
The two sample plugins discussed in this chapter are ``denylist_1.cc``
-and ``basic_auth.cc``. To build and install the example plugins use ::
-
- ./configure --enable-example-plugins
+and ``basic_auth.cc``. To make this two plugins available, you must enable experimental plugins when
+building |TS| by passing the ``-DBUILD_EXPERIMENTAL_PLUGINS=ON`` to the ``cmake`` command
Review Comment:
This looks an "example" plugin. It should be `-DENABLE_EXAMPLE=ON`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Update cmake documentation for experimental plugins. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #11078:
URL: https://github.com/apache/trafficserver/pull/11078#discussion_r1504028904
##########
doc/developer-guide/plugins/example-plugins/index.en.rst:
##########
@@ -48,9 +48,9 @@ understand the following topics:
- Working with HTTP header functions
The two sample plugins discussed in this chapter are ``denylist_1.cc``
-and ``basic_auth.cc``. To build and install the example plugins use ::
-
- ./configure --enable-example-plugins
+and ``basic_auth.cc``. To make this two plugins available, you must enable experimental plugins when
+building |TS| by passing the ``-DBUILD_EXPERIMENTAL_PLUGINS=ON`` to the ``cmake`` command
Review Comment:
you are totally right! :cry: Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org