[GitHub] [incubator-sdap-nexus] skorper opened a new pull request, #196: Address matchup errors and integrate SDAP Proxy changes

[GitBox <gi...@apache.org>]

skorper opened a new pull request, #196:
URL: https://github.com/apache/incubator-sdap-nexus/pull/196

   Prior to this branch, I have been cherry-picking out the SDAP Proxy changes, as they were breaking things in matchup.
   
   This PR addresses those changes, as well as implements feedback provided by the CDMS team.
   
   SDAP Proxy integration fixes:
   
   - Fixed error where matchup openapi spec was no longer being server via tornado
   - Fixed `domslist` endpoint which no longer worked
   - Fixed `cdmssubset` endpoint which no longer worked
   
   Feedback from team changes:
   
   - Remove numInSituRecords and numGriddedChecked from output
   - Change numInSituMatched to numSecondaryMatched and numGriddedMatched to numPrimaryMatched
   - Update parameter value to check against valid variables from in situ schema
   - Added `/domsresults` endpoint to openapi spec
   - Added validation to `parameter` matchup endpoint. `parameter` is validated by using the insitu schema endpoint. Example output if invalid param is provided:
   
   ```
   {
       "error": "Parameter test not supported. Must be one of ['air_pressure', 'air_temperature', 'dew_point_temperature', 'downwelling_longwave_flux_in_air', 'downwelling_longwave_radiance_in_air', 'downwelling_shortwave_flux_in_air', 'mass_concentration_of_chlorophyll_in_sea_water', 'rainfall_rate', 'relative_humidity', 'sea_surface_salinity', 'sea_surface_skin_temperature', 'sea_surface_subskin_temperature', 'sea_surface_temperature', 'sea_water_density', 'sea_water_electrical_conductivity', 'sea_water_practical_salinity', 'sea_water_salinity', 'sea_water_temperature', 'surface_downwelling_photosynthetic_photon_flux_in_air', 'wet_bulb_temperature', 'wind_speed', 'wind_from_direction', 'wind_to_direction', 'eastward_wind', 'northward_wind']",
       "code": 400
   }
   ```
   
   All of the above changes, except for the openAPI spec change, are deployed to the CDMS AWS SDAP deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sdap-nexus] ngachung merged pull request #196: Address matchup errors and integrate SDAP Proxy changes

[GitBox <gi...@apache.org>]

ngachung merged PR #196:
URL: https://github.com/apache/incubator-sdap-nexus/pull/196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org