You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2024/09/09 21:25:00 UTC
[PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
linliu-code opened a new pull request, #11919:
URL: https://github.com/apache/hudi/pull/11919
### Change Logs
When MetaSync class name is empty, the java reflection would throw error.
### Impact
Reduced errors.
### Risk level (write none, low medium or high below)
No.
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code closed pull request #11919: [HUDI-8186] Fix empty meta sync class issue
URL: https://github.com/apache/hudi/pull/11919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #11919:
URL: https://github.com/apache/hudi/pull/11919#discussion_r1751044747
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1037,6 +1037,11 @@ public void runMetaSync() {
Map<String, HoodieException> failedMetaSyncs = new HashMap<>();
for (String impl : syncClientToolClasses) {
+ if (impl.trim().isEmpty()) {
+ LOG.warn("Cannot run MetaSync with empty class name");
Review Comment:
I will try to add a test for this in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11919:
URL: https://github.com/apache/hudi/pull/11919#issuecomment-2339262764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=356",
"triggerID" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=356)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11919:
URL: https://github.com/apache/hudi/pull/11919#discussion_r1751014920
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1037,6 +1037,11 @@ public void runMetaSync() {
Map<String, HoodieException> failedMetaSyncs = new HashMap<>();
for (String impl : syncClientToolClasses) {
+ if (impl.trim().isEmpty()) {
+ LOG.warn("Cannot run MetaSync with empty class name");
Review Comment:
Let's add a small test case so that the test fails before the fix and passes after the fix. Do you need to fix other places? Also seems like this change is already in #11915?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #11919:
URL: https://github.com/apache/hudi/pull/11919#discussion_r1751044560
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1037,6 +1037,11 @@ public void runMetaSync() {
Map<String, HoodieException> failedMetaSyncs = new HashMap<>();
for (String impl : syncClientToolClasses) {
+ if (impl.trim().isEmpty()) {
+ LOG.warn("Cannot run MetaSync with empty class name");
Review Comment:
Then this is a mistake, because I thought I did not submitted it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11919:
URL: https://github.com/apache/hudi/pull/11919#issuecomment-2339167164
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=356",
"triggerID" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=356)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8186] Fix empty meta sync class issue [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11919:
URL: https://github.com/apache/hudi/pull/11919#issuecomment-2339144951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 725c7cc70a9cc85aeb92f7df4cdc0cae7f4f181c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org