You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/08/07 14:27:41 UTC
svn commit: r1892078 - in /poi/trunk/poi/src:
main/java/org/apache/poi/ss/formula/functions/PercentRank.java
test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
Author: fanningpj
Date: Sat Aug 7 14:27:41 2021
New Revision: 1892078
URL: http://svn.apache.org/viewvc?rev=1892078&view=rev
Log:
[bug-49202] add PERCENTRANK function
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java?rev=1892078&r1=1892077&r2=1892078&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/PercentRank.java Sat Aug 7 14:27:41 2021
@@ -89,6 +89,9 @@ public final class PercentRank implement
try {
ValueEval ev = OperandResolver.getSingleValue(args[2], srcRowIndex, srcColumnIndex);
significance = OperandResolver.coerceValueToInt(ev);
+ if (significance < 1) {
+ return ErrorEval.NUM_ERROR;
+ }
} catch (EvaluationException e) {
return e.getErrorEval();
}
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java?rev=1892078&r1=1892077&r2=1892078&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestPercentRank.java Sat Aug 7 14:27:41 2021
@@ -57,6 +57,7 @@ public class TestPercentRank {
confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,0)", FormulaError.NA);
confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,100)", FormulaError.NA);
confirmErrorResult(fe, cell, "PERCENTRANK(B2:B11,100)", FormulaError.NUM);
+ confirmErrorResult(fe, cell, "PERCENTRANK(A2:A11,8,0)", FormulaError.NUM);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org