[jira] [Commented] (SOLR-7043) Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS specific

["Jan Høydahl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318981#comment-14318981 ] 

Jan Høydahl commented on SOLR-7043:
-----------------------------------

+1

Also, should we deprecate the OS-dependent {{solr.in.cmd}} and {{solr.in.sh}} in favor of some new {{solr.yml}} or something? Then SolrCLI would find and parse the file.

> Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS specific
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-7043
>                 URL: https://issues.apache.org/jira/browse/SOLR-7043
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>            Reporter: Timothy Potter
>            Assignee: Timothy Potter
>
> With the 5.0 release, we've reached critical mass with the bin/solr script interface, but we've picked up some cruft along the way. Specifically, there's too much OS-specific constructs in the scripts and they are quite complex overall. They also require extensive manual testing. Moreover, SolrCLI (provides support for the scripts) needs to be refactored to use the Collections API support added to SolrJ instead of using low-level JSON / HTTP constructs. SolrCLI is also in desperate need of a unit test. The overall goal of this ticket is to move as much as possible out of the shell scripts and into SolrCLI, thus increasing test coverage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org