You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/31 09:35:04 UTC
[GitHub] [superset] kgabryje commented on a change in pull request #18009: feat: log scale and step size control for range filters [WIP]
kgabryje commented on a change in pull request #18009:
URL: https://github.com/apache/superset/pull/18009#discussion_r839386326
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
##########
@@ -149,6 +150,7 @@ export default function getControlItemsMap({
(controlItem: CustomControlItem) =>
controlItem?.config?.renderTrigger &&
controlItem.name !== 'sortAscending' &&
+ controlItem?.config?.type !== 'SelectControl' &&
Review comment:
I think that we should rather if the type is `Checkbox` rather than `not SelectControl`
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
##########
@@ -149,6 +150,7 @@ export default function getControlItemsMap({
(controlItem: CustomControlItem) =>
controlItem?.config?.renderTrigger &&
controlItem.name !== 'sortAscending' &&
+ controlItem?.config?.type !== 'SelectControl' &&
Review comment:
I think that we should rather check if the type is `Checkbox` rather than `not SelectControl`
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
##########
@@ -149,6 +150,7 @@ export default function getControlItemsMap({
(controlItem: CustomControlItem) =>
controlItem?.config?.renderTrigger &&
controlItem.name !== 'sortAscending' &&
+ controlItem?.config?.type !== 'SelectControl' &&
Review comment:
I think that we should check if the type is `Checkbox` rather than `not SelectControl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org