You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/02 15:31:08 UTC

[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.03%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.54%   77.57%   +1.03%     
   ==========================================
     Files         934      936       +2     
     Lines       47393    47352      -41     
     Branches     5964     5911      -53     
   ==========================================
   + Hits        36276    36733     +457     
   + Misses      10939    10475     -464     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <100.00%> (+7.68%)` | :arrow_up: |
   | hive | `80.30% <85.18%> (+0.03%)` | :arrow_up: |
   | javascript | `63.72% <25.00%> (-2.57%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+0.04%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+0.04%)` | :arrow_up: |
   | presto | `80.31% <85.18%> (?)` | |
   | python | `81.15% <85.18%> (+0.17%)` | :arrow_up: |
   | sqlite | `80.20% <85.18%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+20.00%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (+14.60%)` | :arrow_up: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [169 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org