You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "RyujiTamaki (via GitHub)" <gi...@apache.org> on 2023/05/02 06:14:37 UTC
[GitHub] [beam] RyujiTamaki opened a new pull request, #26494: Update README.md
RyujiTamaki opened a new pull request, #26494:
URL: https://github.com/apache/beam/pull/26494
**Please** add a meaningful description for your change here
In this pull request, I am addressing some inaccuracies found in the documentation of the README.md file. The following changes have been made:
1. Corrected file name
2. Corrected task name
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva merged pull request #26494: Update README.md
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva merged PR #26494:
URL: https://github.com/apache/beam/pull/26494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26494: Update README.md
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26494:
URL: https://github.com/apache/beam/pull/26494#issuecomment-1540045555
Reminder, please take a look at this pr: @AnandInguva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26494: Update README.md
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26494:
URL: https://github.com/apache/beam/pull/26494#issuecomment-1530956404
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #26494: Update README.md
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26494:
URL: https://github.com/apache/beam/pull/26494#discussion_r1188616653
##########
sdks/python/apache_beam/examples/inference/README.md:
##########
@@ -536,9 +536,9 @@ The pipeline reads rows of pixels corresponding to a digit, performs basic prepr
The model is loaded from the saved model weights. This can be done by passing a function which creates the model and setting the model type as
`ModelType.SAVED_WEIGHTS` to the `TFModelHandler`. The path to saved weights saved using `model.save_weights(path)` should be passed to the `model_path` argument.
-### Dataset and model for language modeling
+### Dataset and model for digit classification
-To use this transform, you need a dataset and model for language modeling.
+To use this transform, you need a dataset and model for digit classification.
Review Comment:
```suggestion
To use this transform, you need a dataset and model for MNIST digit classification.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26494: Update README.md
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26494:
URL: https://github.com/apache/beam/pull/26494#issuecomment-1530952196
## [Codecov](https://codecov.io/gh/apache/beam/pull/26494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26494](https://codecov.io/gh/apache/beam/pull/26494?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abd4201) into [master](https://codecov.io/gh/apache/beam/commit/68e19a596a5d0136ba4592be01888f487463c2f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68e19a5) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26494 +/- ##
==========================================
+ Coverage 81.12% 81.13% +0.01%
==========================================
Files 469 469
Lines 67424 67424
==========================================
+ Hits 54695 54702 +7
+ Misses 12729 12722 -7
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.13% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 5 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26494/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] RyujiTamaki commented on a diff in pull request #26494: Update README.md
Posted by "RyujiTamaki (via GitHub)" <gi...@apache.org>.
RyujiTamaki commented on code in PR #26494:
URL: https://github.com/apache/beam/pull/26494#discussion_r1189252306
##########
sdks/python/apache_beam/examples/inference/README.md:
##########
@@ -536,9 +536,9 @@ The pipeline reads rows of pixels corresponding to a digit, performs basic prepr
The model is loaded from the saved model weights. This can be done by passing a function which creates the model and setting the model type as
`ModelType.SAVED_WEIGHTS` to the `TFModelHandler`. The path to saved weights saved using `model.save_weights(path)` should be passed to the `model_path` argument.
-### Dataset and model for language modeling
+### Dataset and model for digit classification
-To use this transform, you need a dataset and model for language modeling.
+To use this transform, you need a dataset and model for digit classification.
Review Comment:
@AnandInguva
I've made the requested changes and pushed the updated commit. Please take another look when you have a chance. Thank you for your feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org