You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:11:45 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4074: Allow searching networks using name in api

ravening opened a new pull request #4074:
URL: https://github.com/apache/cloudstack/pull/4074


   ## Description
   Add a new parameter "name" to search for network using its name
   
   (local) 🐵 > list networks name=shared-network
   {
     "count": 1,
     "network": [
       {
         "acltype": "Domain",
         "broadcastdomaintype": "Vlan",
         "broadcasturi": "vlan://113",
         "canusefordeploy": true,
         "cidr": "10.1.1.0/24",
         "details": {},
         "displaynetwork": true,
         "displaytext": "shared-network",
         "dns1": "8.8.8.8",
         "domain": "ROOT",
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   Through cloudmonkey api
   
   ```
   (local) 🐵 > list networks name=shared-network
   {
     "count": 1,
     "network": [
       {
         "acltype": "Domain",
         "broadcastdomaintype": "Vlan",
         "broadcasturi": "vlan://113",
         "canusefordeploy": true,
         "cidr": "10.1.1.0/24",
         "details": {},
         "displaynetwork": true,
         "displaytext": "shared-network",
         "dns1": "8.8.8.8",
   ```
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4074: Allow searching networks using name in api

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4074:
URL: https://github.com/apache/cloudstack/pull/4074#issuecomment-640393800


   > -1
   > @ravening can you explain why we need that when we already can search by name using the `keyword` parameter?
   
   @rhtyd sorry for the delayed response. Yes "keyword" is working fine. I will close this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening closed pull request #4074: Allow searching networks using name in api

Posted by GitBox <gi...@apache.org>.
ravening closed pull request #4074:
URL: https://github.com/apache/cloudstack/pull/4074


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4074: Allow searching networks using name in api

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4074:
URL: https://github.com/apache/cloudstack/pull/4074#issuecomment-638559561


   -1
   @ravening can you explain why we need that when we already can search by name using the `keyword` parameter?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4074: Allow searching networks using name in api

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4074:
URL: https://github.com/apache/cloudstack/pull/4074#issuecomment-633933749


   @ravening there is a keyword parameter that is used to search by name, isn't that working?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org