[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed <task>-restore-time metric.
URL: https://github.com/apache/samza/pull/942#discussion_r263535250
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
 ##########
 @@ -573,6 +576,25 @@ private StorageEngine createStore(String storeName, TaskName taskName, TaskModel
     return this.sideInputStorageManagers.values().stream().collect(Collectors.toSet());
   }
 
+  /**
+   * Registers any CSM created metrics such as side-inputs related metrics, and standby-task related metrics.
+   * @param metricsReporters metrics reporters to use
+   */
+  public void registerMetrics(Map<String, MetricsReporter> metricsReporters) {
 
 Review comment:
   That's true, but that pattern doesn't work in this case because both the CSM and SamzaContainer need to have a different registry because they both create SystemConsumersMetrics. Using the same registry causes a conflict in the metrics' name. 
   
   We do use this pattern in TaskInstance, where each TaskInstance is given a set of reporters and it registers its metrics there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services