[GitHub] [beam] lostluck commented on pull request #13194: [Beam-4115] Enable Go SDK vanity import path

[GitBox <gi...@apache.org>]

lostluck commented on pull request #13194:
URL: https://github.com/apache/beam/pull/13194#issuecomment-717438716


   Wowee! Big change :D
   
   I don't think it's possible to break it up though? Vanity URLs are tricky in that respect and I wrote that original doc before Modules were available in earnest.
   
   I do agree that it would warrant a mention in the CHANGES file.
   
   The big trick here will be making sure that the jenkins tests also all pass before merging. No rush, as we aren't likely going to merge this in before the 2.26 cut (november 5th), to make sure that we can get it properly stable before the next cut.
   
   Another thing to consider is whether to also make the module + v2 switch happen at the same time, since that's what the git repo tags will be saying anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org