You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:00:48 UTC
[GitHub] [beam] ruslan-ikhsan opened a new pull request, #24920: Tourofbeam+infrastructure
ruslan-ikhsan opened a new pull request, #24920:
URL: https://github.com/apache/beam/pull/24920
PR resolves #
R: @olehborysevych
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1131040467
##########
learning/tour-of-beam/terraform/main.tf:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module "setup" {
+ source = "./setup"
+ project_id = var.project_id
+ service_account_id = var.service_account_id
+ depends_on = [module.api_enable]
+}
+
+module "functions_buckets" {
+ source = "./functions_buckets"
+ # project_id = var.project_id
Review Comment:
Unneeded line is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1126546765
##########
learning/tour-of-beam/terraform/main.tf:
##########
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module "setup" {
+ source = "./setup"
+ project_id = var.project_id
+ service_account_id = var.service_account_id
+ depends_on = [module.api_enable]
+}
+
+module "functions_buckets" {
+ source = "./functions_buckets"
+ # project_id = var.project_id
Review Comment:
please remove unneeded line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1126362843
##########
learning/tour-of-beam/terraform/api_enable/main.tf:
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+resource "google_project_service" "required_services" {
+ project = var.project_id
+ for_each = toset([
+ "cloudresourcemanager",
+ "iam",
+ "cloudbuild",
+ "cloudfunctions",
+ "firebase"
+ ])
+ service = "${each.key}.googleapis.com"
+ disable_on_destroy = false
+}
+
+resource "null_resource" "enable_cf_admin" {
+ provisioner "local-exec" {
+ command = "gcloud projects add-iam-policy-binding ${var.project_id} --member=user:$(gcloud config get-value core/account) --role=roles/cloudfunctions.admin --condition=None"
Review Comment:
can we use [google_project_iam_binding](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/google_project_iam#google_project_iam_binding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1131038241
##########
.gitignore:
##########
@@ -139,3 +139,5 @@ playground/frontend/playground_components_dev/pubspec.lock
# Ignore Katas auto-generated files
**/*-remote-info.yaml
+*.dart
Review Comment:
.dart removed and pubspec.lock file path included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1131042017
##########
learning/tour-of-beam/terraform/api_enable/main.tf:
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+resource "google_project_service" "required_services" {
+ project = var.project_id
+ for_each = toset([
+ "cloudresourcemanager",
+ "iam",
+ "cloudbuild",
+ "cloudfunctions",
+ "firebase"
+ ])
+ service = "${each.key}.googleapis.com"
+ disable_on_destroy = false
+}
+
+resource "null_resource" "enable_cf_admin" {
+ provisioner "local-exec" {
+ command = "gcloud projects add-iam-policy-binding ${var.project_id} --member=user:$(gcloud config get-value core/account) --role=roles/cloudfunctions.admin --condition=None"
Review Comment:
Null_resource has been removed, and replaced with google_project_iam_binding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1129800975
##########
playground/terraform/build.gradle.kts:
##########
@@ -56,6 +56,7 @@ tasks {
}
args(
"init", "-migrate-state",
+ "-auto-approve",
Review Comment:
Added by mistake, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1114380643
##########
.gitignore:
##########
@@ -139,3 +139,5 @@ playground/frontend/playground_components_dev/pubspec.lock
# Ignore Katas auto-generated files
**/*-remote-info.yaml
+*.dart
Review Comment:
I don't think we need to ignore *.dart files ))
##########
.gitignore:
##########
@@ -139,3 +139,5 @@ playground/frontend/playground_components_dev/pubspec.lock
# Ignore Katas auto-generated files
**/*-remote-info.yaml
+*.dart
Review Comment:
also let's put the whole path to pubspec.lock and move it higher in the Dart/Flutter section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1104452028
##########
learning/tour-of-beam/terraform/variables.tf:
##########
@@ -0,0 +1,40 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+variable "bucket_name" {
Review Comment:
I would advise to change name to something like "cf_bucket_name" to better see the purpose of this variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1126358463
##########
learning/tour-of-beam/terraform/api_enable/main.tf:
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+resource "google_project_service" "required_services" {
+ project = var.project_id
+ for_each = toset([
+ "cloudresourcemanager",
+ "iam",
+ "cloudbuild",
+ "cloudfunctions",
+ "firebase"
+ ])
+ service = "${each.key}.googleapis.com"
+ disable_on_destroy = false
+}
+
+resource "null_resource" "enable_cf_admin" {
+ provisioner "local-exec" {
+ command = "gcloud projects add-iam-policy-binding ${var.project_id} --member=user:$(gcloud config get-value core/account) --role=roles/cloudfunctions.admin --condition=None"
Review Comment:
Is there other way to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1131039960
##########
learning/tour-of-beam/frontend/.firebaserc:
##########
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
File will be created during grade task now, file removed from PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1129800975
##########
playground/terraform/build.gradle.kts:
##########
@@ -56,6 +56,7 @@ tasks {
}
args(
"init", "-migrate-state",
+ "-auto-approve",
Review Comment:
Good point, redundant flag, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on PR #24920:
URL: https://github.com/apache/beam/pull/24920#issuecomment-1466417760
Closed as new duplicated PR has been created to maintain clean commit history
New PR: https://github.com/apache/beam/pull/25793
CC: @olehborysevych
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan closed pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan closed pull request #24920: Tourofbeam+infrastructure
URL: https://github.com/apache/beam/pull/24920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24920: Tourofbeam+infrastructure
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24920:
URL: https://github.com/apache/beam/pull/24920#issuecomment-1442781369
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24920: Tourofbeam+infrastructure
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24920:
URL: https://github.com/apache/beam/pull/24920#issuecomment-1377750717
# [Codecov](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24920](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c4a6a3) into [master](https://codecov.io/gh/apache/beam/commit/44c9d0278c067c46ffd2f68fc3fd850f11f998ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44c9d02) will **decrease** coverage by `16.32%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24920 +/- ##
===========================================
- Coverage 73.25% 56.93% -16.33%
===========================================
Files 725 728 +3
Lines 97444 97602 +158
===========================================
- Hits 71384 55568 -15816
- Misses 24710 40684 +15974
Partials 1350 1350
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `59.29% <ø> (-23.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/utils.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdXRpbHMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/ml/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvX19pbml0X18ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/shared.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmVkLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/ml/inference/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL19faW5pdF9fLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [sdks/python/apache\_beam/examples/snippets/util.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdXRpbC5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/python/apache\_beam/typehints/testing/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3Rlc3RpbmcvX19pbml0X18ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../python/apache\_beam/io/gcp/datastore/v1new/util.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy91dGlsLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../python/apache\_beam/testing/analyzers/constants.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9hbmFseXplcnMvY29uc3RhbnRzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...python/apache\_beam/typehints/testing/strategies.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3Rlc3Rpbmcvc3RyYXRlZ2llcy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ache\_beam/coders/proto2\_coder\_test\_messages\_pb2.py](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Byb3RvMl9jb2Rlcl90ZXN0X21lc3NhZ2VzX3BiMi5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [251 more](https://codecov.io/gh/apache/beam/pull/24920?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1126260469
##########
learning/tour-of-beam/frontend/lib/models/unit_content.g.dart:
##########
@@ -9,11 +9,11 @@ part of 'unit_content.dart';
UnitContentModel _$UnitContentModelFromJson(Map<String, dynamic> json) =>
UnitContentModel(
id: json['id'] as String,
- title: json['title'] as String,
description: json['description'] as String,
- taskSnippetId: json['taskSnippetId'] as String?,
- solutionSnippetId: json['solutionSnippetId'] as String?,
hints:
(json['hints'] as List<dynamic>?)?.map((e) => e as String).toList() ??
[],
+ solutionSnippetId: json['solutionSnippetId'] as String?,
Review Comment:
can we revert this change? I don't think this is required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1127922131
##########
learning/tour-of-beam/frontend/.firebaserc:
##########
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
check if we can create it from scratch instead of modifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1126639164
##########
playground/terraform/build.gradle.kts:
##########
@@ -56,6 +56,7 @@ tasks {
}
args(
"init", "-migrate-state",
+ "-auto-approve",
Review Comment:
why we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ruslan-ikhsan commented on a diff in pull request #24920: Tourofbeam+infrastructure
Posted by "ruslan-ikhsan (via GitHub)" <gi...@apache.org>.
ruslan-ikhsan commented on code in PR #24920:
URL: https://github.com/apache/beam/pull/24920#discussion_r1131042270
##########
learning/tour-of-beam/frontend/lib/models/unit_content.g.dart:
##########
@@ -9,11 +9,11 @@ part of 'unit_content.dart';
UnitContentModel _$UnitContentModelFromJson(Map<String, dynamic> json) =>
UnitContentModel(
id: json['id'] as String,
- title: json['title'] as String,
description: json['description'] as String,
- taskSnippetId: json['taskSnippetId'] as String?,
- solutionSnippetId: json['solutionSnippetId'] as String?,
hints:
(json['hints'] as List<dynamic>?)?.map((e) => e as String).toList() ??
[],
+ solutionSnippetId: json['solutionSnippetId'] as String?,
Review Comment:
Change has been reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org