You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dtenedor (via GitHub)" <gi...@apache.org> on 2024/05/30 21:59:26 UTC

[PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

dtenedor opened a new pull request, #46815:
URL: https://github.com/apache/spark/pull/46815

   ### What changes were proposed in this pull request?
   
   Migrate logging with variables of the Spark `RPackageUtils` module to structured logging framework. This transforms the log* entries of APIs like this:
   
   ```
   def logWarning(msg: => String): Unit
   ```
   to
   ```
   def logWarning(entry: LogEntry): Unit
   ```
   
   ### Why are the changes needed?
   
   To enhance Apache Spark's logging system by implementing structured logging.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, Spark core logs will contain additional MDC
   
   ### How was this patch tested?
   
   Compiler and scala style checks, as well as code review.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Brief but appropriate use of GitHub copilot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on code in PR #46815:
URL: https://github.com/apache/spark/pull/46815#discussion_r1621543094


##########
core/src/main/scala/org/apache/spark/deploy/RPackageUtils.scala:
##########


Review Comment:
   Thanks, and sorry for missing it :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #46815:
URL: https://github.com/apache/spark/pull/46815#issuecomment-2140925868

   cc @gengliangwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang closed pull request #46815: [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework
URL: https://github.com/apache/spark/pull/46815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on code in PR #46815:
URL: https://github.com/apache/spark/pull/46815#discussion_r1621482311


##########
core/src/main/scala/org/apache/spark/deploy/RPackageUtils.scala:
##########


Review Comment:
   @dtenedor I planned to skip this one since we disabled the structured logging for `sparkR` shell in https://github.com/apache/spark/pull/46383/files#diff-f8564df81d845c0cd2f621bc2ed22761cbf9731f28cb2828d9cbd0491f4e7584R74.
   But since you made the changes, we can still merge this one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47578][R] Migrate RPackageUtils with variables to structured logging framework [spark]

Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #46815:
URL: https://github.com/apache/spark/pull/46815#issuecomment-2142637955

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org