[jira] [Commented] (FLINK-6516) using real row count instead of dummy row count when optimizing plan

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003965#comment-16003965 ] 

ASF GitHub Bot commented on FLINK-6516:
---------------------------------------

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/3860

    [FLINK-6516] [table] using real row count instead of dummy row count when optimizing plan

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-6516

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3860
    
----
commit 4914c1858aecbb57c86ea474a551f41eaab13b34
Author: godfreyhe <go...@163.com>
Date:   2017-05-10T03:14:06Z

    [FLINK-6516] [table] using real row count instead of dummy row count when optimizing plan

----


> using real row count instead of dummy row count when optimizing plan
> --------------------------------------------------------------------
>
>                 Key: FLINK-6516
>                 URL: https://issues.apache.org/jira/browse/FLINK-6516
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: godfrey he
>            Assignee: godfrey he
>
> Currently, the statistic of {{TableSourceTable}} is {{UNKNOWN}} mostly, and the statistic from {{ExternalCatalog}} maybe is null also. Actually, only each {{TableSource}} knows its statistic exactly, especial for {{FilterableTableSource}} and {{PartitionableTableSource}}. So we can add {{getTableStats}} method in {{TableSource}}, and use it in TableSourceScan's estimateRowCount method to get real row count.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)