[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a diff in pull request #2182: The lite-core module decouples ZooKeeper

["TeslaCN (via GitHub)" <gi...@apache.org>]

TeslaCN commented on code in PR #2182:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2182#discussion_r1136686431


##########
elasticjob-lite/elasticjob-lite-core/pom.xml:
##########
@@ -125,5 +121,11 @@
             <artifactId>logback-classic</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.shardingsphere.elasticjob</groupId>
+            <artifactId>elasticjob-registry-center-zookeeper-curator</artifactId>
+            <version>${project.parent.version}</version>
+            <scope>test</scope>

Review Comment:
   Could we consider setting it `runtime`? Otherwise users need to introduce it sperately.



##########
elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/api/registry/JobInstanceRegistry.java:
##########
@@ -17,9 +17,14 @@
 
 package org.apache.shardingsphere.elasticjob.lite.api.registry;
 
+import java.util.Arrays;

Review Comment:
   There are too many unrelated changes in this PR. Please revert them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org