[GitHub] [spark] amaliujia commented on a diff in pull request #40467: [SPARK-42584][CONNECT] Improve output of `Column.explain`

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40467:
URL: https://github.com/apache/spark/pull/40467#discussion_r1142418545


##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -163,6 +164,14 @@ message AnalyzePlanRequest {
     // (Required) The logical plan to get a hashCode.
     Plan plan = 1;
   }
+
+  // Explains the expression based on extended is true or not.
+  message ExplainExpression {
+    // (Required) The expression to be analyzed.
+    Expression expr = 1;
+
+    bool extended = 2;

Review Comment:
   Nit: please follow the style guide to indicate if this is required or optional and also document the semantics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org