You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Deepak Dixit (JIRA)" <ji...@apache.org> on 2018/12/16 10:57:00 UTC
[jira] [Commented] (OFBIZ-10712) Inconsistent behaviour of
ServiceDispatcher.checkAuth
[ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722452#comment-16722452 ]
Deepak Dixit commented on OFBIZ-10712:
--------------------------------------
Here is the Patch for this issue, If we are doing service.makeValid so it should be executed for all the service irrespective of permissionServiceCheck.
> Inconsistent behaviour of ServiceDispatcher.checkAuth
> ------------------------------------------------------
>
> Key: OFBIZ-10712
> URL: https://issues.apache.org/jira/browse/OFBIZ-10712
> Project: OFBiz
> Issue Type: Bug
> Reporter: Deepak Dixit
> Priority: Major
> Attachments: OFBIZ-10712.patch
>
>
> We have checkAuth method in service dispatcher class, this method performs multiple auth related check.
> if all checks passed it call the modelService.makeValid method to prepare service context (line#960) but this code executed only when service definition has a permission service call.
> If service does not have any permission service call then it does not call the modelService.makeValid and this may cause the service validation issue unknown parameter found.
> Ideally modelService.makeValid should call irrespective to permission service check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)