You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/04 02:16:37 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #212: [YUNIKORN-477] Include K8s 1.18 to e2e test matrix
yangwwei opened a new pull request #212:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #212: [YUNIKORN-477] Include K8s 1.18 to e2e test matrix
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #212:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/212#issuecomment-738609139
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=h1) Report
> Merging [#212](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=desc) (0bace54) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 58.29% 57.95% -0.35%
==========================================
Files 33 33
Lines 2928 2928
==========================================
- Hits 1707 1697 -10
- Misses 1149 1158 +9
- Partials 72 73 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.82% <0.00%> (-4.68%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=footer). Last update [42e5a34...0bace54](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #212: [YUNIKORN-477] Include K8s 1.18 to e2e test matrix
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #212:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/212#issuecomment-738609139
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=h1) Report
> Merging [#212](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=desc) (c901aee) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 33 33
Lines 2928 2928
=======================================
Hits 1707 1707
Misses 1149 1149
Partials 72 72
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=footer). Last update [42e5a34...0bace54](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton closed pull request #212: [YUNIKORN-477] Include K8s 1.18 to e2e test matrix
Posted by GitBox <gi...@apache.org>.
kingamarton closed pull request #212:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #212: [YUNIKORN-477] Include K8s 1.18 to e2e test matrix
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #212:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/212#issuecomment-738609139
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=h1) Report
> Merging [#212](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=desc) (c901aee) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 33 33
Lines 2928 2928
=======================================
Hits 1707 1707
Misses 1149 1149
Partials 72 72
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=footer). Last update [42e5a34...c901aee](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org