You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by atrbgithub <gi...@git.apache.org> on 2015/10/16 22:19:33 UTC
[GitHub] cloudstack pull request: Sorting of security groups
GitHub user atrbgithub opened a pull request:
https://github.com/apache/cloudstack/pull/937
Sorting of security groups
Simple change to sort the security groups in alphabetical order within the instance creation wizard.
This makes it much easier to find a security group when the user is presented with a long list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/autotraderuk/cloudstack sec-group-sorting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #937
----
commit ff7a5bbd9b615818bb4b4691df0fc8d9170a0c5d
Author: atrbgithub <at...@gmail.com>
Date: 2015-10-16T20:13:51Z
Sorting of security groups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Sorting of security groups
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149888063
Hi @DaanHoogland , I've raised jira ticket for this request: https://issues.apache.org/jira/browse/CLOUDSTACK-8976
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Sorting of security groups
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149943690
thanks @atrbgithub , please add the string "CLOUDSTACK-8976" to the title of the PR. It will probably be merged in after 4.6 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-153686857
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Sorting of security groups
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149817205
@atrbgithub @rafaelweingartner LGTM with only code inspection. @remibergsma @karuturi one to put on the great pile for batch testing. It is trivial and a great fix.
@atrbgithub can you enter a jira ticket for it and adjust the title to reflect it? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149966515
NP, sorry we are in a freeze
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8976 - Sorting of security gro...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149964321
@DaanHoogland Sorry about that. Sorted now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Sorting of security groups
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149743155
Nice work
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---