You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2017/11/22 06:21:22 UTC
Question regarding WICKET-6497 unify javascript files
Hello,
I'm currently investigating "WICKET-6497 unify javascript files".
As far as I understand Wicket unifies JS code blocks, but not JS references
So the only options are:
1) create 1 JS file and put contents of these 2 in it
2) perform combining at compile time using maven plugin [1]
I can implement 2) above. Would it be OK? Maybe there are better options?
[1] http://samaxes.github.io/minify-maven-plugin/usage.html
--
WBR
Maxim aka solomax
Re: Question regarding WICKET-6497 unify javascript files
Posted by Maxim Solodovnik <so...@gmail.com>.
Additionally resources can have jquery as dependency, in this case it will
be applied twice ....
I'm merging 2 files and removing references
to WicketEventJQueryResourceReference ....
On Wed, Nov 22, 2017 at 9:27 PM, Martin Grigorov <mg...@apache.org>
wrote:
> On Wed, Nov 22, 2017 at 3:44 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > minify-plugin can merge any number of JS files
> > But I'm not sure merge everything is a good idea ....
> >
>
> I'd prefer jQuery to be served from CDN for my apps.
>
>
> >
> > On Wed, Nov 22, 2017 at 5:56 PM, Korbinian Bachl <
> > korbinian.bachl@whiskyworld.de> wrote:
> >
> > > Hello,
> > >
> > > wouldn't option 2 put the Jjqery.js into it?
> > >
> > > Best,
> > >
> > > KB
> > >
> > > ----- Ursprüngliche Mail -----
> > > > Von: "Maxim Solodovnik" <so...@gmail.com>
> > > > An: dev@wicket.apache.org
> > > > Gesendet: Mittwoch, 22. November 2017 07:21:22
> > > > Betreff: Question regarding WICKET-6497 unify javascript files
> > >
> > > > Hello,
> > > >
> > > > I'm currently investigating "WICKET-6497 unify javascript files".
> > > > As far as I understand Wicket unifies JS code blocks, but not JS
> > > references
> > > >
> > > > So the only options are:
> > > > 1) create 1 JS file and put contents of these 2 in it
> > > > 2) perform combining at compile time using maven plugin [1]
> > > >
> > > > I can implement 2) above. Would it be OK? Maybe there are better
> > options?
> > > >
> > > > [1] http://samaxes.github.io/minify-maven-plugin/usage.html
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
--
WBR
Maxim aka solomax
Re: Question regarding WICKET-6497 unify javascript files
Posted by Martin Grigorov <mg...@apache.org>.
On Wed, Nov 22, 2017 at 3:44 PM, Maxim Solodovnik <so...@gmail.com>
wrote:
> minify-plugin can merge any number of JS files
> But I'm not sure merge everything is a good idea ....
>
I'd prefer jQuery to be served from CDN for my apps.
>
> On Wed, Nov 22, 2017 at 5:56 PM, Korbinian Bachl <
> korbinian.bachl@whiskyworld.de> wrote:
>
> > Hello,
> >
> > wouldn't option 2 put the Jjqery.js into it?
> >
> > Best,
> >
> > KB
> >
> > ----- Ursprüngliche Mail -----
> > > Von: "Maxim Solodovnik" <so...@gmail.com>
> > > An: dev@wicket.apache.org
> > > Gesendet: Mittwoch, 22. November 2017 07:21:22
> > > Betreff: Question regarding WICKET-6497 unify javascript files
> >
> > > Hello,
> > >
> > > I'm currently investigating "WICKET-6497 unify javascript files".
> > > As far as I understand Wicket unifies JS code blocks, but not JS
> > references
> > >
> > > So the only options are:
> > > 1) create 1 JS file and put contents of these 2 in it
> > > 2) perform combining at compile time using maven plugin [1]
> > >
> > > I can implement 2) above. Would it be OK? Maybe there are better
> options?
> > >
> > > [1] http://samaxes.github.io/minify-maven-plugin/usage.html
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Question regarding WICKET-6497 unify javascript files
Posted by Maxim Solodovnik <so...@gmail.com>.
minify-plugin can merge any number of JS files
But I'm not sure merge everything is a good idea ....
On Wed, Nov 22, 2017 at 5:56 PM, Korbinian Bachl <
korbinian.bachl@whiskyworld.de> wrote:
> Hello,
>
> wouldn't option 2 put the Jjqery.js into it?
>
> Best,
>
> KB
>
> ----- Ursprüngliche Mail -----
> > Von: "Maxim Solodovnik" <so...@gmail.com>
> > An: dev@wicket.apache.org
> > Gesendet: Mittwoch, 22. November 2017 07:21:22
> > Betreff: Question regarding WICKET-6497 unify javascript files
>
> > Hello,
> >
> > I'm currently investigating "WICKET-6497 unify javascript files".
> > As far as I understand Wicket unifies JS code blocks, but not JS
> references
> >
> > So the only options are:
> > 1) create 1 JS file and put contents of these 2 in it
> > 2) perform combining at compile time using maven plugin [1]
> >
> > I can implement 2) above. Would it be OK? Maybe there are better options?
> >
> > [1] http://samaxes.github.io/minify-maven-plugin/usage.html
> >
> > --
> > WBR
> > Maxim aka solomax
>
--
WBR
Maxim aka solomax
Re: Question regarding WICKET-6497 unify javascript files
Posted by Korbinian Bachl <ko...@whiskyworld.de>.
Hello,
wouldn't option 2 put the Jjqery.js into it?
Best,
KB
----- Ursprüngliche Mail -----
> Von: "Maxim Solodovnik" <so...@gmail.com>
> An: dev@wicket.apache.org
> Gesendet: Mittwoch, 22. November 2017 07:21:22
> Betreff: Question regarding WICKET-6497 unify javascript files
> Hello,
>
> I'm currently investigating "WICKET-6497 unify javascript files".
> As far as I understand Wicket unifies JS code blocks, but not JS references
>
> So the only options are:
> 1) create 1 JS file and put contents of these 2 in it
> 2) perform combining at compile time using maven plugin [1]
>
> I can implement 2) above. Would it be OK? Maybe there are better options?
>
> [1] http://samaxes.github.io/minify-maven-plugin/usage.html
>
> --
> WBR
> Maxim aka solomax
Re: Question regarding WICKET-6497 unify javascript files
Posted by Martin Grigorov <mg...@apache.org>.
I vote for 1)
Move the contents of wicket-event-jquery.js to wicket-ajax-jquery.js
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Nov 22, 2017 at 8:21 AM, Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello,
>
> I'm currently investigating "WICKET-6497 unify javascript files".
> As far as I understand Wicket unifies JS code blocks, but not JS references
>
> So the only options are:
> 1) create 1 JS file and put contents of these 2 in it
> 2) perform combining at compile time using maven plugin [1]
>
> I can implement 2) above. Would it be OK? Maybe there are better options?
>
> [1] http://samaxes.github.io/minify-maven-plugin/usage.html
>
> --
> WBR
> Maxim aka solomax
>